Propagate media session id into MediaPlayerAndroid

media/base/android/media_codec_player_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/android/media_codec_player.h"
 
 #include <stdint.h>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 626 matching lines @@
   }
 }
 
 void MediaCodecPlayerTest::CreatePlayer() {
   DCHECK(demuxer_);
   player_ = new MediaCodecPlayer(
       0,  // player_id
       manager_.GetWeakPtr(),
       base::Bind(&MockMediaPlayerManager::OnMediaResourcesRequested,
                  base::Unretained(&manager_)),
-      scoped_ptr<MockDemuxerAndroid>(demuxer_), GURL());
+      scoped_ptr<MockDemuxerAndroid>(demuxer_), GURL(), 0);

[davve, 2016/02/25 09:57:32]

I have the constant problem here as well (as in the previous CL). Not what the
best place for the constant is. Including blink headers from doesn't seem right,
or?

[mlamouri (slow - plz ping), 2016/02/25 14:13:55]

Hmm, maybe you should have version of the constant in media/base/ and one in
content/? I'm afraid media/base/ will not be able to access content/ nor blink
but I think we need a constant instead of a plain 0 here.

(We could even add a build time assert to check that the media/ and content/
constants are the same.)

[whywhat, 2016/02/29 16:26:29]

What is 0? The default session? Is it used anywhere but tests?

[davve, 2016/03/01 05:42:22]

Yes, the default session. Not used much yet, but I think we eventually will need
a notion of the default media session in media/ and content/browser/

 
   DCHECK(player_);
 }
 
 void MediaCodecPlayerTest::SetVideoSurface() {
   surface_texture_a_ = gfx::SurfaceTexture::Create(0);
   gfx::ScopedJavaSurface surface(surface_texture_a_.get());
 
   ASSERT_NE(nullptr, player_);
   player_->SetVideoSurface(std::move(surface));
@@ skipping 1617 matching lines @@
   // TODO(timav): maybe we should not call the testing callback for
   // kRenderAfterPreroll for video (for audio we already do not call).
   // EXPECT_TRUE(AlmostEqual(manager_.FirstFrameTime(DemuxerStream::AUDIO),
   //                        manager_.FirstFrameTime(DemuxerStream::VIDEO), 50));
 
   // The playback should start at |seek_position|
   EXPECT_TRUE(AlmostEqual(seek_position, manager_.pts_stat_.min(), 25));
 }
 
 }  // namespace media