media/base/android/media_codec_player_unittest.cc - Issue 1640123004: Propagate media session id into MediaPlayerAndroid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/android/media_codec_player_unittest.cc

Issue 1640123004: Propagate media session id into MediaPlayerAndroid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pass-media-session-id-over-ipc

Patch Set: Add TODO for remote playback interaction Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media/android/remote/remote_media_player_bridge.cc ('K') | « media/base/android/media_codec_player.cc ('k') | media/base/android/media_player_android.h » ('j') | media/base/android/media_player_android.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/base/android/media_codec_player_unittest.cc

diff --git a/media/base/android/media_codec_player_unittest.cc b/media/base/android/media_codec_player_unittest.cc

index 10ce91cf3a35678b93d12c59bf4b5259730c6d60..1abd23484c7dfa85b5a7299805a987e8d0a0ee4d 100644

--- a/media/base/android/media_codec_player_unittest.cc

+++ b/media/base/android/media_codec_player_unittest.cc

@@ -644,7 +644,7 @@ void MediaCodecPlayerTest::CreatePlayer() {

manager_.GetWeakPtr(),

base::Bind(&MockMediaPlayerManager::OnMediaResourcesRequested,

base::Unretained(&manager_)),

- scoped_ptr<MockDemuxerAndroid>(demuxer_), GURL());

+ scoped_ptr<MockDemuxerAndroid>(demuxer_), GURL(), kDefaultMediaSessionID);

DCHECK(player_);

}