Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5327)

Unified Diff: chrome/browser/media/android/remote/remote_media_player_bridge.cc

Issue 1640123004: Propagate media session id into MediaPlayerAndroid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pass-media-session-id-over-ipc
Patch Set: Add TODO for remote playback interaction Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/android/remote/remote_media_player_bridge.cc
diff --git a/chrome/browser/media/android/remote/remote_media_player_bridge.cc b/chrome/browser/media/android/remote/remote_media_player_bridge.cc
index bcb4dab3453d1985b88eacba41fd007e6ea6eb9e..41d728561c549614892fc5d211996a0a88b066fc 100644
--- a/chrome/browser/media/android/remote/remote_media_player_bridge.cc
+++ b/chrome/browser/media/android/remote/remote_media_player_bridge.cc
@@ -43,10 +43,15 @@ RemoteMediaPlayerBridge::RemoteMediaPlayerBridge(
const std::string& user_agent,
bool hide_url_log,
RemoteMediaPlayerManager* manager)
- : MediaPlayerAndroid(player_id,
- manager,
- base::Bind(&DoNothing),
- manager->GetLocalPlayer(player_id)->frame_url()),
+ : MediaPlayerAndroid(
+ player_id,
+ manager,
+ base::Bind(&DoNothing),
+ manager->GetLocalPlayer(player_id)->frame_url(),
+ // TODO(davve): Media session interaction with remote
+ // playback not defined. Use default session for now.
+ // https://github.com/whatwg/mediasession/issues/123
+ media::kDefaultMediaSessionID),
whywhat 2016/03/10 22:34:56 What does using the default session mean in practi
davve 2016/03/11 13:20:29 Ok, kInvalidMediaSessionId it is.
width_(0),
height_(0),
hide_url_log_(hide_url_log),

Powered by Google App Engine
This is Rietveld 408576698