Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 1640043002: Mac (cleanup): Remove WebDialogs. (Closed)

Created:
4 years, 11 months ago by tapted
Modified:
4 years, 11 months ago
Reviewers:
Robert Sesek, msw
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac (cleanup): Remove WebDialogs. Nothing uses these on Mac. They're used a lot on ChromeOS. On Windows, it shows a default browser selection dialog. On Linux it shows the certificate viewer. On Mac I think it was once used for a webui task manager. BUG=None Committed: https://crrev.com/e0eec37304a55f38b31e4c6693fb274eb7ffeea3 Cr-Commit-Position: refs/heads/master@{#371971}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -515 lines) Patch
M chrome/browser/ui/browser_dialogs.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/ui/cocoa/web_dialog_window_controller.h View 1 chunk +0 lines, -55 lines 0 comments Download
D chrome/browser/ui/cocoa/web_dialog_window_controller.mm View 1 chunk +0 lines, -350 lines 0 comments Download
D chrome/browser/ui/cocoa/web_dialog_window_controller_unittest.mm View 1 chunk +0 lines, -101 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
tapted
Hi Robert - please take a look
4 years, 11 months ago (2016-01-27 04:13:01 UTC) #6
Robert Sesek
LGTM!
4 years, 11 months ago (2016-01-27 22:16:47 UTC) #7
tapted
+msw for OWNERS in chrome/browser/ui/browser_dialogs.h (just hiding the `ShowWebDialog` symbol on Mac to match reality).
4 years, 11 months ago (2016-01-28 02:04:21 UTC) #9
msw
lgtm
4 years, 11 months ago (2016-01-28 02:26:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640043002/1
4 years, 11 months ago (2016-01-28 02:29:28 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-28 02:45:42 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-28 02:47:05 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0eec37304a55f38b31e4c6693fb274eb7ffeea3
Cr-Commit-Position: refs/heads/master@{#371971}

Powered by Google App Engine
This is Rietveld 408576698