Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8348)

Unified Diff: chrome/browser/ui/cocoa/web_dialog_window_controller_unittest.mm

Issue 1640043002: Mac (cleanup): Remove WebDialogs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/web_dialog_window_controller.mm ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/web_dialog_window_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/web_dialog_window_controller_unittest.mm b/chrome/browser/ui/cocoa/web_dialog_window_controller_unittest.mm
deleted file mode 100644
index 488420ef24160e45264e125dc4e3c64946c6b79f..0000000000000000000000000000000000000000
--- a/chrome/browser/ui/cocoa/web_dialog_window_controller_unittest.mm
+++ /dev/null
@@ -1,101 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#import "chrome/browser/ui/cocoa/web_dialog_window_controller.h"
-
-#include <string>
-#include <vector>
-
-#import <Cocoa/Cocoa.h>
-
-#import "base/mac/scoped_nsautorelease_pool.h"
-#include "base/strings/sys_string_conversions.h"
-#include "base/strings/utf_string_conversions.h"
-#include "chrome/browser/ui/browser.h"
-#include "chrome/browser/ui/cocoa/cocoa_test_helper.h"
-#include "chrome/test/base/browser_with_test_window_test.h"
-#include "chrome/test/base/testing_profile.h"
-#include "content/public/browser/web_ui.h"
-#include "content/public/browser/web_ui_message_handler.h"
-#include "testing/gmock/include/gmock/gmock.h"
-#include "testing/gtest/include/gtest/gtest.h"
-#include "ui/gfx/geometry/size.h"
-#include "ui/web_dialogs/web_dialog_delegate.h"
-#include "url/gurl.h"
-
-using content::WebContents;
-using content::WebUIMessageHandler;
-using ui::WebDialogDelegate;
-
-namespace {
-
-class MockDelegate : public WebDialogDelegate {
-public:
- MOCK_CONST_METHOD0(GetDialogModalType, ui::ModalType());
- MOCK_CONST_METHOD0(GetDialogTitle, base::string16());
- MOCK_CONST_METHOD0(GetDialogContentURL, GURL());
- MOCK_CONST_METHOD1(GetWebUIMessageHandlers,
- void(std::vector<WebUIMessageHandler*>*));
- MOCK_CONST_METHOD1(GetDialogSize, void(gfx::Size*));
- MOCK_CONST_METHOD0(GetDialogArgs, std::string());
- MOCK_METHOD1(OnDialogClosed, void(const std::string& json_retval));
- MOCK_METHOD2(OnCloseContents,
- void(WebContents* source, bool* out_close_dialog));
- MOCK_CONST_METHOD0(ShouldShowDialogTitle, bool());
-};
-
-class WebDialogWindowControllerTest : public BrowserWithTestWindowTest {
- public:
- void SetUp() override {
- BrowserWithTestWindowTest::SetUp();
- CocoaTest::BootstrapCocoa();
- title_ = base::ASCIIToUTF16("Mock Title");
- size_ = gfx::Size(50, 100);
- gurl_ = GURL("");
- }
-
- protected:
- base::string16 title_;
- gfx::Size size_;
- GURL gurl_;
-
- // Order here is important.
- MockDelegate delegate_;
-};
-
-using ::testing::_;
-using ::testing::Return;
-using ::testing::SetArgumentPointee;
-
-// TODO(akalin): We can't test much more than the below without a real browser.
-// In particular, GetWebUIMessageHandlers() and GetDialogArgs() are never
-// called. This should be fixed.
-
-TEST_F(WebDialogWindowControllerTest, showDialog) {
- // We want to make sure web_dialog_window_controller below gets
- // destroyed before delegate_, so we specify our own autorelease pool.
- //
- // TODO(dmaclach): Remove this once
- // http://code.google.com/p/chromium/issues/detail?id=26133 is fixed.
- base::mac::ScopedNSAutoreleasePool release_pool;
-
- EXPECT_CALL(delegate_, GetDialogTitle())
- .WillOnce(Return(title_));
- EXPECT_CALL(delegate_, GetDialogSize(_))
- .WillOnce(SetArgumentPointee<0>(size_));
- EXPECT_CALL(delegate_, GetDialogContentURL())
- .WillOnce(Return(gurl_));
- EXPECT_CALL(delegate_, OnDialogClosed(_))
- .Times(1);
-
- WebDialogWindowController* web_dialog_window_controller =
- [[WebDialogWindowController alloc] initWithDelegate:&delegate_
- context:profile()];
-
- [web_dialog_window_controller loadDialogContents];
- [web_dialog_window_controller showWindow:nil];
- [web_dialog_window_controller close];
-}
-
-} // namespace
« no previous file with comments | « chrome/browser/ui/cocoa/web_dialog_window_controller.mm ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698