Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/error_page/renderer/net_error_helper_core_unittest.cc

Issue 1639953002: Network error interstitial update - add suggestions list (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix browser and unit tests Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/net/dns_probe_browsertest.cc ('K') | « components/error_page/renderer/net_error_helper_core.cc ('k') | components/error_page_strings.grdp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/error_page/renderer/net_error_helper_core_unittest.cc
diff --git a/components/error_page/renderer/net_error_helper_core_unittest.cc b/components/error_page/renderer/net_error_helper_core_unittest.cc
index cf046093fc03a40ed320d8dc67699ad8c6acc7ac..15f9ab2fdc2ff6accb759643cf71f68ede77d9cd 100644
--- a/components/error_page/renderer/net_error_helper_core_unittest.cc
+++ b/components/error_page/renderer/net_error_helper_core_unittest.cc
@@ -342,7 +342,7 @@ class NetErrorHelperCoreTest : public testing::Test,
// Checks that the last error page params correspond to kDefaultSuggestions.
ASSERT_TRUE(last_error_page_params());
EXPECT_TRUE(last_error_page_params()->suggest_reload);
- EXPECT_EQ(2u, last_error_page_params()->override_suggestions->GetSize());
+ EXPECT_EQ(1u, last_error_page_params()->override_suggestions->GetSize());
edwardjung 2016/02/25 19:00:03 Only showing 1 suggestion now.
EXPECT_EQ(GURL(kSearchUrl), last_error_page_params()->search_url);
EXPECT_EQ(kSuggestedSearchTerms, last_error_page_params()->search_terms);
}
« chrome/browser/net/dns_probe_browsertest.cc ('K') | « components/error_page/renderer/net_error_helper_core.cc ('k') | components/error_page_strings.grdp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698