chrome/browser/net/dns_probe_browsertest.cc - Issue 1639953002: Network error interstitial update - add suggestions list

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/dns_probe_browsertest.cc

Issue 1639953002: Network error interstitial update - add suggestions list (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix browser and unit tests Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/errorpage_browsertest.cc ('k') | components/error_page/common/localized_error.cc » ('j') | components/error_page/renderer/net_error_helper_core_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/dns_probe_browsertest.cc

diff --git a/chrome/browser/net/dns_probe_browsertest.cc b/chrome/browser/net/dns_probe_browsertest.cc

index c9cf76fffaa5608400c2d12d904a11b3039207e0..c66a8364ce244ea8f35dc55f5fa5515b8ea15d8b 100644

--- a/chrome/browser/net/dns_probe_browsertest.cc

+++ b/chrome/browser/net/dns_probe_browsertest.cc

@@ -650,15 +650,13 @@ bool DnsProbeBrowserTest::PageContains(const std::string& expected) {

void DnsProbeBrowserTest::ExpectDisplayingLocalErrorPage(

const std::string& status_text) {

- EXPECT_FALSE(PageContains("http://correction1/"));

- EXPECT_FALSE(PageContains("http://correction2/"));

+ EXPECT_FALSE(PageContains("http://mock.http/title2.html"));

edwardjung 2016/02/25 19:00:03 Changed URLs as showing only the first URL suggest

EXPECT_TRUE(PageContains(status_text));

}

void DnsProbeBrowserTest::ExpectDisplayingCorrections(

const std::string& status_text) {

- EXPECT_TRUE(PageContains("http://correction1/"));

- EXPECT_TRUE(PageContains("http://correction2/"));

+ EXPECT_TRUE(PageContains("http://mock.http/title2.html"));

EXPECT_TRUE(PageContains(status_text));

}