Add attachToWindow event to infobar observer

Add attachToWindow event to infobar observer

When a user switches tabs while the infobar container is showing,
its state is not saved and it is possible for events in the currently
active tab to reset reader mode's knowledge of the infobars. This
change introduces an event "onInfobarContainerAttachedToWindow" that
notifies observers when the infobar container is attached and if
it needs to show any infobars.

BUG=579036
Committed: https://crrev.com/272723546ec1414b2d6b28e511935a3a9b8141d1
Cr-Commit-Position: refs/heads/master@{#371634}

[mdjones, 2016-01-26 01:56:31]

Description was changed from

==========
Add observer for attach to window

When a user switches tabs while the infobar container is showing,
its state is not saved and it is possible for events in the currently
active tab to reset reader mode's knowledge of the infobars. This
change introduces an event "onInfobarContainerAttachedToWindow" that
notifies observers when the infobar container is attached and if
it needs to show any infobars.

BUG=579036
==========

to

==========
Add attachToWindow event to infobar observer

When a user switches tabs while the infobar container is showing,
its state is not saved and it is possible for events in the currently
active tab to reset reader mode's knowledge of the infobars. This
change introduces an event "onInfobarContainerAttachedToWindow" that
notifies observers when the infobar container is attached and if
it needs to show any infobars.

BUG=579036
==========

[mdjones, 2016-01-26 01:56:45]

mdjones@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[mdjones, 2016-01-26 01:56:45]

PTAL

[gone, 2016-01-26 20:18:32]

https://chromiumcodereview.appspot.com/1639673002/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java
(right):

https://chromiumcodereview.appspot.com/1639673002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java:276:
public void onInfobarContainerAttachedToWindow(boolean hasInfobars) {
onInfoBarContainerAttachedToWindow
      ^

https://chromiumcodereview.appspot.com/1639673002/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java
(right):

https://chromiumcodereview.appspot.com/1639673002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java:242:
super.setVisibility(visibility);
Is this even necessary?

https://chromiumcodereview.appspot.com/1639673002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java:371:
}
Do you want this to be fired here, or only if the InfoBar is not obscured?  If
it's obscured, it stays invisible because of Contextual Search (yay spaghetti
logic).

[mdjones, 2016-01-26 21:58:17]

https://chromiumcodereview.appspot.com/1639673002/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java
(right):

https://chromiumcodereview.appspot.com/1639673002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java:276:
public void onInfobarContainerAttachedToWindow(boolean hasInfobars) {
On 2016/01/26 20:18:32, dfalcantara wrote:
> onInfoBarContainerAttachedToWindow
>       ^

Done.

https://chromiumcodereview.appspot.com/1639673002/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java
(right):

https://chromiumcodereview.appspot.com/1639673002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java:242:
super.setVisibility(visibility);
On 2016/01/26 20:18:32, dfalcantara wrote:
> Is this even necessary?

Nope.

https://chromiumcodereview.appspot.com/1639673002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java:371:
}
On 2016/01/26 20:18:32, dfalcantara wrote:
> Do you want this to be fired here, or only if the InfoBar is not obscured?  If
> it's obscured, it stays invisible because of Contextual Search (yay spaghetti
> logic).

Infobars always have priority over reader mode. Even if the view is being
obscured, I still need to know if it got attached and if there are any infobars
trying to be displayed.

[gone, 2016-01-26 22:01:10]

lgtm % s///g

https://chromiumcodereview.appspot.com/1639673002/diff/20001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java
(right):

https://chromiumcodereview.appspot.com/1639673002/diff/20001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java:277:
mIsInfobarContainerShown = hasInfobars;
s/InfobarContainer/InfoBarContainer/g

[mdjones, 2016-01-26 22:47:11]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2016-01-26 22:47:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/1639673002/#ps40001
(title: "nit")

[mdjones, 2016-01-26 22:47:31]

On 2016/01/26 22:01:10, dfalcantara wrote:
> lgtm % s///g
> 
>
https://chromiumcodereview.appspot.com/1639673002/diff/20001/chrome/android/j...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java
> (right):
> 
>
https://chromiumcodereview.appspot.com/1639673002/diff/20001/chrome/android/j...
>
chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java:277:
> mIsInfobarContainerShown = hasInfobars;
> s/InfobarContainer/InfoBarContainer/g

Fixed.

[commit-bot: I haz the power, 2016-01-26 22:47:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1639673002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1639673002/40001

[commit-bot: I haz the power, 2016-01-26 23:37:42]

Description was changed from

==========
Add attachToWindow event to infobar observer

When a user switches tabs while the infobar container is showing,
its state is not saved and it is possible for events in the currently
active tab to reset reader mode's knowledge of the infobars. This
change introduces an event "onInfobarContainerAttachedToWindow" that
notifies observers when the infobar container is attached and if
it needs to show any infobars.

BUG=579036
==========

to

==========
Add attachToWindow event to infobar observer

When a user switches tabs while the infobar container is showing,
its state is not saved and it is possible for events in the currently
active tab to reset reader mode's knowledge of the infobars. This
change introduces an event "onInfobarContainerAttachedToWindow" that
notifies observers when the infobar container is attached and if
it needs to show any infobars.

BUG=579036
==========

[commit-bot: I haz the power, 2016-01-26 23:37:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-26 23:38:57]

Description was changed from

==========
Add attachToWindow event to infobar observer

When a user switches tabs while the infobar container is showing,
its state is not saved and it is possible for events in the currently
active tab to reset reader mode's knowledge of the infobars. This
change introduces an event "onInfobarContainerAttachedToWindow" that
notifies observers when the infobar container is attached and if
it needs to show any infobars.

BUG=579036
==========

to

==========
Add attachToWindow event to infobar observer

When a user switches tabs while the infobar container is showing,
its state is not saved and it is possible for events in the currently
active tab to reset reader mode's knowledge of the infobars. This
change introduces an event "onInfobarContainerAttachedToWindow" that
notifies observers when the infobar container is attached and if
it needs to show any infobars.

BUG=579036

Committed: https://crrev.com/272723546ec1414b2d6b28e511935a3a9b8141d1
Cr-Commit-Position: refs/heads/master@{#371634}
==========

[commit-bot: I haz the power, 2016-01-26 23:38:58]

Patchset 3 (id:??) landed as
https://crrev.com/272723546ec1414b2d6b28e511935a3a9b8141d1
Cr-Commit-Position: refs/heads/master@{#371634}