Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4496)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java

Issue 1639673002: Add attachToWindow event to infobar observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java b/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java
index ab944dc89e87da58a0818246532ed865f6d501b4..d3098a1dddb30aef84000c064f7cfe51b30064c2 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java
@@ -85,7 +85,7 @@ public class ReaderModeManager extends TabModelSelectorTabObserver
private final int mHeaderBackgroundColor;
private boolean mIsFullscreenModeEntered;
- private boolean mIsInfobarContainerShown;
+ private boolean mIsInfoBarContainerShown;
private boolean mIsFindToolbarShowing;
public ReaderModeManager(TabModelSelector selector, ChromeActivity activity) {
@@ -258,7 +258,7 @@ public class ReaderModeManager extends TabModelSelectorTabObserver
public void onAddInfoBar(InfoBarContainer container, InfoBar infoBar, boolean isFirst) {
// Temporarily hides the reader mode button while the infobars are shown.
if (isFirst) {
- mIsInfobarContainerShown = true;
+ mIsInfoBarContainerShown = true;
closeReaderPanel(StateChangeReason.INFOBAR_SHOWN, false);
}
}
@@ -267,7 +267,17 @@ public class ReaderModeManager extends TabModelSelectorTabObserver
public void onRemoveInfoBar(InfoBarContainer container, InfoBar infoBar, boolean isLast) {
// Re-shows the reader mode button if necessary once the infobars are dismissed.
if (isLast) {
- mIsInfobarContainerShown = false;
+ mIsInfoBarContainerShown = false;
+ requestReaderPanelShow(StateChangeReason.INFOBAR_HIDDEN);
+ }
+ }
+
+ @Override
+ public void onInfoBarContainerAttachedToWindow(boolean hasInfoBars) {
+ mIsInfoBarContainerShown = hasInfoBars;
+ if (mIsInfoBarContainerShown) {
+ closeReaderPanel(StateChangeReason.INFOBAR_SHOWN, false);
+ } else {
requestReaderPanelShow(StateChangeReason.INFOBAR_HIDDEN);
}
}
@@ -394,7 +404,7 @@ public class ReaderModeManager extends TabModelSelectorTabObserver
if (mReaderModePanel == null || !mTabStatusMap.containsKey(currentTabId)
|| mTabStatusMap.get(currentTabId).getStatus() != POSSIBLE
|| mTabStatusMap.get(currentTabId).isDismissed()
- || mIsInfobarContainerShown
+ || mIsInfoBarContainerShown
|| mIsFindToolbarShowing
|| mIsFullscreenModeEntered
|| DeviceClassManager.isAccessibilityModeEnabled(mChromeActivity)) {
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698