Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Side by Side Diff: tools/clang/rewrite_to_chrome_style/tests/variables-original.cc

Issue 1639663003: Clean up rewrite_to_chrome_style naming logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More comprehensive fixes Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 namespace blink { 5 namespace blink {
6 6
7 // Global variables 7 // Global variables
8 int frameCount = 0; 8 int frameCount = 0;
9 // Make sure that underscore-insertion doesn't get too confused by acronyms. 9 // Make sure that underscore-insertion doesn't get too confused by acronyms.
10 static int variableMentioningHTTPAndHTTPS = 1; 10 static int variableMentioningHTTPAndHTTPS = 1;
11 // Already Google style, should not change. 11 // Already Google style, should not change.
12 int already_google_style_; 12 int already_google_style_;
13 // Should still get normalized.
14 int Goofily_named_VARIABLE_for_FUN_;
15 // "A" should be considered its own word.
16 int nthAValue;
17 // "V8" and "Data" should be distinct words.
18 int myV8Data;
19 // "UTF8" and "Data" should be distinct words.
20 int myUTF8Data;
21 // "Latin1" and "Data" should be distinct words.
22 int myLatin1Data;
23 // Identifiers that are all the same case should just be split by underscore,
24 // aka assume the human knows what they're doing.
25 int GL_COMPRESSED_RGB_PVRTC_4BPPV1_IMG;
26 int GL_COMPRESSED_RGB_S3TC_DXT1_EXT;
27 // Weird edge cases.
28 int myDataFromUTF8MaskingTop8Bits;
29 bool enableUnsafeES3APIs;
13 30
14 // Function parameters 31 // Function parameters
15 int function(int interestingNumber) { 32 int function(int interestingNumber) {
16 // Local variables. 33 // Local variables.
17 int aLocalVariable = 1; 34 int aLocalVariable = 1;
18 // Static locals. 35 // Static locals.
19 static int aStaticLocalVariable = 2; 36 static int aStaticLocalVariable = 2;
20 // Make sure references to variables are also rewritten. 37 // Make sure references to variables are also rewritten.
21 return frameCount + 38 return frameCount +
22 variableMentioningHTTPAndHTTPS * interestingNumber / aLocalVariable % 39 variableMentioningHTTPAndHTTPS * interestingNumber / aLocalVariable %
23 aStaticLocalVariable; 40 aStaticLocalVariable;
24 } 41 }
25 42
26 } // namespace blink 43 } // namespace blink
27 44
28 int F() { 45 int F() {
29 // Make sure variables qualified with a namespace name are still rewritten 46 // Make sure variables qualified with a namespace name are still rewritten
30 // correctly. 47 // correctly.
31 return blink::frameCount; 48 return blink::frameCount;
32 } 49 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698