Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1639643003: Revert of [Password manager] Temporarily add some CHECKs to investigate a crash (Closed)

Created:
4 years, 11 months ago by vabr (Chromium)
Modified:
4 years, 11 months ago
Reviewers:
Mike West
CC:
browser-components-watch_chromium.org, chromium-reviews, estade+watch_chromium.org, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org, rouslan+autofillwatch_chromium.org, vabr+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Password manager] Temporarily add some CHECKs to investigate a crash (patchset #1 id:1 of https://codereview.chromium.org/1139863003/ ) Reason for revert: The associated bug got closed, the crash is no longer observed since version 43, so the checks are overdue to be removed. Original issue's description: > [Password manager] Temporarily add some CHECKs to investigate a crash > > Add some CHECKs to see if some of the hypotheses in http://crbug.com/486931#c3 (however unlikely they seem) could be right. > This is in line with https://www.chromium.org/developers/coding-style#TOC-CHECK-DCHECK-and-NOTREACHED-. > > BUG=486931 > > Committed: https://crrev.com/3e966cacd118b489ab195f03446812c7eaedfc8f > Cr-Commit-Position: refs/heads/master@{#329393} TBR=mkwst@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=486931

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M chrome/browser/ui/passwords/manage_passwords_state.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/autofill/core/common/password_form.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/autofill/core/common/password_form.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vabr (Chromium)
Created Revert of [Password manager] Temporarily add some CHECKs to investigate a crash
4 years, 11 months ago (2016-01-26 13:25:23 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639643003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639643003/1
4 years, 11 months ago (2016-01-26 13:25:58 UTC) #3
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 13:27:39 UTC) #5
Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

Powered by Google App Engine
This is Rietveld 408576698