chrome/browser/ui/passwords/manage_passwords_state.cc - Issue 1639643003: Revert of [Password manager] Temporarily add some CHECKs to investigate a crash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_state.cc

Issue 1639643003: Revert of [Password manager] Temporarily add some CHECKs to investigate a crash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/passwords/manage_passwords_state.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_state.cc b/chrome/browser/ui/passwords/manage_passwords_state.cc

index d4e63413dee78d1297ea29bc78a6f65eca40b827..457b6ecc6838898f95ed668a2acb4e70abe49a58 100644

--- a/chrome/browser/ui/passwords/manage_passwords_state.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_state.cc

@@ -149,8 +149,7 @@

void ManagePasswordsState::OnPasswordAutofilled(

const PasswordFormMap& password_form_map) {

- // TODO(vabr): Revert back to DCHECK once http://crbug.com/486931 is fixed.

- CHECK(!password_form_map.empty());

+ DCHECK(!password_form_map.empty());

ClearData();

if (password_form_map.begin()->second->IsPublicSuffixMatch()) {

// Don't show the UI for PSL matched passwords. They are not stored for this

« no previous file with comments | « no previous file | components/autofill/core/common/password_form.h » ('j') | no next file with comments »