Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 1639623002: win_toolchain: Ignore ReportQueue entries in calculating toolchain hash (Closed)

Created:
4 years, 11 months ago by scottmg
Modified:
4 years, 11 months ago
Reviewers:
brucedawson
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

win_toolchain: Ignore ReportQueue entries in calculating toolchain hash Without this, we'd cause unnecessary toolchain redownloads if vctip.exe crashed. R=brucedawson@chromium.org BUG=440500 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298393

Patch Set 1 #

Patch Set 2 : WER\ReportQueue #

Patch Set 3 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M win_toolchain/get_toolchain_if_necessary.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
scottmg
4 years, 11 months ago (2016-01-25 23:51:41 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639623002/20001
4 years, 11 months ago (2016-01-25 23:54:09 UTC) #4
brucedawson
lgtm
4 years, 11 months ago (2016-01-25 23:55:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639623002/20001
4 years, 11 months ago (2016-01-25 23:56:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639623002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639623002/40001
4 years, 11 months ago (2016-01-25 23:57:08 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 23:59:02 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298393

Powered by Google App Engine
This is Rietveld 408576698