Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: win_toolchain/get_toolchain_if_necessary.py

Issue 1639623002: win_toolchain: Ignore ReportQueue entries in calculating toolchain hash (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: typo Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: win_toolchain/get_toolchain_if_necessary.py
diff --git a/win_toolchain/get_toolchain_if_necessary.py b/win_toolchain/get_toolchain_if_necessary.py
index 07e82729eee15089c6fbe9d90f4d8e99d580a6c9..0b6e62d726b88f1628cc6e43973adc322423470c 100755
--- a/win_toolchain/get_toolchain_if_necessary.py
+++ b/win_toolchain/get_toolchain_if_necessary.py
@@ -74,7 +74,9 @@ def GetFileList(root):
file_list = []
for base, _, files in os.walk(root):
paths = [os.path.join(base, f) for f in files]
- file_list.extend(x.lower() for x in paths)
+ # Ignore WER ReportQueue entries that vctip/cl leave in the bin dir if/when
+ # they crash.
+ file_list.extend(x.lower() for x in paths if 'WER\\ReportQueue' not in x)
return sorted(file_list, key=lambda s: s.replace('/', '\\'))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698