[Autofill] Fill from the last digits when filling a phone number with a maximum length.

components/autofill/core/browser/autofill_manager_unittest.cc

Index: components/autofill/core/browser/autofill_manager_unittest.cc
diff --git a/components/autofill/core/browser/autofill_manager_unittest.cc b/components/autofill/core/browser/autofill_manager_unittest.cc
index 7d3b09b7ffe81ff4418408ab7b86960d4895b8d2..b48a3b25380b893aabf9af7689fbd22e4963606d 100644
--- a/components/autofill/core/browser/autofill_manager_unittest.cc
+++ b/components/autofill/core/browser/autofill_manager_unittest.cc
@@ -2554,7 +2554,8 @@ TEST_F(AutofillManagerTest, FillPhoneNumber) {
   EXPECT_EQ(base::string16(), response_data2.fields[4].value);
 
   // We should not be able to fill prefix and suffix fields for international

[Mathieu, 2016/01/27 14:30:49]

// We should not be able to fill international numbers correctly in a form
containing fields with US max_length. 

Question for seb: we should probably detect those cases and just give up? Let's
file a bug about this.

[sebsg, 2016/01/27 21:01:21]

Done.

-  // numbers.
+  // numbers. However, the number should have the number of digits equal to the
+  // max lenght specified, starting from the right.

[Mathieu, 2016/01/27 14:30:49]

*length

[sebsg, 2016/01/27 21:01:21]

Done.

   work_profile->SetRawInfo(ADDRESS_HOME_COUNTRY, ASCIIToUTF16("GB"));
   work_profile->SetRawInfo(PHONE_HOME_WHOLE_NUMBER,
                            ASCIIToUTF16("447700954321"));
@@ -2567,10 +2568,10 @@ TEST_F(AutofillManagerTest, FillPhoneNumber) {
   EXPECT_EQ(3, response_page_id);
 
   ASSERT_EQ(5U, response_data3.fields.size());
-  EXPECT_EQ(ASCIIToUTF16("44"), response_data3.fields[0].value);
-  EXPECT_EQ(ASCIIToUTF16("7700"), response_data3.fields[1].value);
-  EXPECT_EQ(ASCIIToUTF16("954321"), response_data3.fields[2].value);
-  EXPECT_EQ(ASCIIToUTF16("954321"), response_data3.fields[3].value);
+  EXPECT_EQ(ASCIIToUTF16("4"), response_data3.fields[0].value);

[Mathieu, 2016/01/27 14:30:49]

This is weird (a few digits truncated from each field). We should really revisit
international phone numbers soon, as mentioned above.

[sebsg, 2016/01/27 21:01:21]

Acknowledged.

+  EXPECT_EQ(ASCIIToUTF16("700"), response_data3.fields[1].value);
+  EXPECT_EQ(ASCIIToUTF16("321"), response_data3.fields[2].value);
+  EXPECT_EQ(ASCIIToUTF16("4321"), response_data3.fields[3].value);
   EXPECT_EQ(base::string16(), response_data3.fields[4].value);
 
   page_id = 4;