[Autofill] Fill from the last digits when filling a phone number with a maximum length.

components/autofill/core/browser/autofill_manager_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <vector>
 
 #include "base/command_line.h"
@@ skipping 2455 matching lines @@
   {
     SCOPED_TRACE("Credit card 2");
     ExpectFilledForm(response_page_id, response_data, kPageID3, "", "", "", "",
                      "", "", "", "", "", "", "", "", "", "", "2012", true, true,
                      false);
   }
 }
 
 // Test that we correctly fill a phone number split across multiple fields.
 TEST_F(AutofillManagerTest, FillPhoneNumber) {
   // In one form, rely on the maxlength attribute to imply phone number parts.

[Mathieu, 2016/01/27 14:30:49]

imply US phone number parts.

[sebsg, 2016/01/27 21:01:21]

Done.

   // In the other form, rely on the autocompletetype attribute.
   FormData form_with_maxlength;

[Mathieu, 2016/01/27 14:30:49]

Rename to |form_with_us_number_max_length|

[sebsg, 2016/01/27 21:01:21]

Done.

   form_with_maxlength.name = ASCIIToUTF16("MyMaxlengthPhoneForm");
   form_with_maxlength.origin = GURL("http://myform.com/phone_form.html");
   form_with_maxlength.action = GURL("http://myform.com/phone_submit.html");
   FormData form_with_autocompletetype = form_with_maxlength;
   form_with_autocompletetype.name = ASCIIToUTF16("MyAutocompletetypePhoneForm");
 
   struct {
     const char* label;
     const char* name;
     size_t max_length;
@@ skipping 57 matching lines @@
                                      &response_page_id, &response_data2);
   EXPECT_EQ(2, response_page_id);
 
   ASSERT_EQ(5U, response_data2.fields.size());
   EXPECT_EQ(ASCIIToUTF16("1"), response_data2.fields[0].value);
   EXPECT_EQ(ASCIIToUTF16("650"), response_data2.fields[1].value);
   EXPECT_EQ(ASCIIToUTF16("555"), response_data2.fields[2].value);
   EXPECT_EQ(ASCIIToUTF16("4567"), response_data2.fields[3].value);
   EXPECT_EQ(base::string16(), response_data2.fields[4].value);
 
   // We should not be able to fill prefix and suffix fields for international

[Mathieu, 2016/01/27 14:30:49]

// We should not be able to fill international numbers correctly in a form
containing fields with US max_length. 

Question for seb: we should probably detect those cases and just give up? Let's
file a bug about this.

[sebsg, 2016/01/27 21:01:21]

Done.

-  // numbers.
+  // numbers. However, the number should have the number of digits equal to the
+  // max lenght specified, starting from the right.

[Mathieu, 2016/01/27 14:30:49]

*length

[sebsg, 2016/01/27 21:01:21]

Done.

   work_profile->SetRawInfo(ADDRESS_HOME_COUNTRY, ASCIIToUTF16("GB"));
   work_profile->SetRawInfo(PHONE_HOME_WHOLE_NUMBER,
                            ASCIIToUTF16("447700954321"));
   page_id = 3;
   response_page_id = 0;
   FormData response_data3;
   FillAutofillFormDataAndSaveResults(
       page_id, form_with_maxlength, *form_with_maxlength.fields.begin(),
       MakeFrontendID(std::string(), guid), &response_page_id, &response_data3);
   EXPECT_EQ(3, response_page_id);
 
   ASSERT_EQ(5U, response_data3.fields.size());
-  EXPECT_EQ(ASCIIToUTF16("44"), response_data3.fields[0].value);
-  EXPECT_EQ(ASCIIToUTF16("7700"), response_data3.fields[1].value);
-  EXPECT_EQ(ASCIIToUTF16("954321"), response_data3.fields[2].value);
-  EXPECT_EQ(ASCIIToUTF16("954321"), response_data3.fields[3].value);
+  EXPECT_EQ(ASCIIToUTF16("4"), response_data3.fields[0].value);

[Mathieu, 2016/01/27 14:30:49]

This is weird (a few digits truncated from each field). We should really revisit
international phone numbers soon, as mentioned above.

[sebsg, 2016/01/27 21:01:21]

Acknowledged.

+  EXPECT_EQ(ASCIIToUTF16("700"), response_data3.fields[1].value);
+  EXPECT_EQ(ASCIIToUTF16("321"), response_data3.fields[2].value);
+  EXPECT_EQ(ASCIIToUTF16("4321"), response_data3.fields[3].value);
   EXPECT_EQ(base::string16(), response_data3.fields[4].value);
 
   page_id = 4;
   response_page_id = 0;
   FormData response_data4;
   FillAutofillFormDataAndSaveResults(page_id, form_with_autocompletetype,
                                      *form_with_autocompletetype.fields.begin(),
                                      MakeFrontendID(std::string(), guid),
                                      &response_page_id, &response_data4);
   EXPECT_EQ(4, response_page_id);
@@ skipping 1627 matching lines @@
   FormsSeen(mixed_forms);
 
   // Suggestions should always be displayed.
   for (const FormFieldData& field : mixed_form.fields) {
     GetAutofillSuggestions(mixed_form, field);
     EXPECT_TRUE(external_delegate_->on_suggestions_returned_seen());
   }
 }
 
 }  // namespace autofill