Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 1639533003: Record static constant public fields. (Closed)

Created:
4 years, 11 months ago by scheglov
Modified:
4 years, 11 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Serialize only constant constructors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -98 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 8 chunks +28 lines, -21 lines 0 comments Download
M pkg/analyzer/lib/src/summary/prelink.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/public_namespace_computer.dart View 1 2 chunks +16 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 1 3 chunks +38 lines, -30 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 1 2 chunks +71 lines, -40 lines 0 comments Download
M pkg/analyzer/tool/summary/idl.dart View 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 11 months ago (2016-01-26 17:16:28 UTC) #1
Paul Berry
lgtm https://codereview.chromium.org/1639533003/diff/1/pkg/analyzer/lib/src/summary/summarize_elements.dart File pkg/analyzer/lib/src/summary/summarize_elements.dart (right): https://codereview.chromium.org/1639533003/diff/1/pkg/analyzer/lib/src/summary/summarize_elements.dart#newcode403 pkg/analyzer/lib/src/summary/summarize_elements.dart:403: if (constructor.isPublic && !constructor.isSynthetic) { Let's just store ...
4 years, 11 months ago (2016-01-26 18:16:49 UTC) #2
scheglov
https://codereview.chromium.org/1639533003/diff/1/pkg/analyzer/lib/src/summary/summarize_elements.dart File pkg/analyzer/lib/src/summary/summarize_elements.dart (right): https://codereview.chromium.org/1639533003/diff/1/pkg/analyzer/lib/src/summary/summarize_elements.dart#newcode403 pkg/analyzer/lib/src/summary/summarize_elements.dart:403: if (constructor.isPublic && !constructor.isSynthetic) { On 2016/01/26 18:16:49, Paul ...
4 years, 11 months ago (2016-01-26 18:44:14 UTC) #3
scheglov
4 years, 11 months ago (2016-01-26 18:44:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8485e42a27423da9a3f7f32e694d0ac2b8b93159 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698