Record static constant public fields.

pkg/analyzer/lib/src/summary/summarize_elements.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library serialization.elements;
 
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/dart/element/type.dart';
 import 'package:analyzer/src/dart/element/element.dart';
 import 'package:analyzer/src/dart/element/type.dart';
@@ skipping 165 matching lines @@
             name: accessor.name,
             numTypeParameters: accessor.typeParameters.length));
       }
     }
     for (ClassElement cls in compilationUnit.types) {
       if (cls.isPublic) {
         names.add(new UnlinkedPublicNameBuilder(
             kind: ReferenceKind.classOrEnum,
             name: cls.name,
             numTypeParameters: cls.typeParameters.length,
-            executables: serializePublicStaticMethodsAndConstructors(cls)));
+            constMembers: serializeClassConstMembers(cls)));
       }
     }
     for (ClassElement enm in compilationUnit.enums) {
       if (enm.isPublic) {
         names.add(new UnlinkedPublicNameBuilder(
             kind: ReferenceKind.classOrEnum, name: enm.name));
       }
     }
     for (FunctionElement function in compilationUnit.functions) {
       if (function.isPublic) {
@@ skipping 172 matching lines @@
     }
     b.fields = fields;
     b.executables = executables;
     b.isAbstract = classElement.isAbstract;
     b.isMixinApplication = classElement.isMixinApplication;
     b.documentationComment = serializeDocumentation(classElement);
     return b;
   }
 
   /**
+   * If [cls] is a class, return the list of its members available for
+   * constants - static constant fields, static methods and constructors.
+   * Otherwise return `null`.
+   */
+  List<UnlinkedPublicNameBuilder> serializeClassConstMembers(ClassElement cls) {
+    if (cls.kind == ElementKind.CLASS) {
+      List<UnlinkedPublicNameBuilder> bs = <UnlinkedPublicNameBuilder>[];
+      for (FieldElement field in cls.fields) {
+        if (field.isStatic && field.isConst && field.isPublic) {
+          bs.add(new UnlinkedPublicNameBuilder(
+              name: field.name,
+              kind: ReferenceKind.constField,
+              numTypeParameters: 0));
+        }
+      }
+      for (MethodElement method in cls.methods) {
+        if (method.isStatic && method.isPublic) {
+          bs.add(new UnlinkedPublicNameBuilder(
+              name: method.name,
+              kind: ReferenceKind.staticMethod,
+              numTypeParameters: method.typeParameters.length));
+        }
+      }
+      for (ConstructorElement constructor in cls.constructors) {
+        if (constructor.isPublic && !constructor.isSynthetic) {

[Paul Berry, 2016/01/26 18:16:49]

Let's just store the const constructors since they're the only ones that can be
validly referred to.

[scheglov, 2016/01/26 18:44:14]

Done.

+          bs.add(new UnlinkedPublicNameBuilder(
+              name: constructor.name,
+              kind: ReferenceKind.constructor,
+              numTypeParameters: 0));
+        }
+      }
+      return bs;
+    }
+    return null;
+  }
+
+  /**
    * Serialize the given [combinator] into an [UnlinkedCombinator].
    */
   UnlinkedCombinatorBuilder serializeCombinator(
       NamespaceCombinator combinator) {
     UnlinkedCombinatorBuilder b = new UnlinkedCombinatorBuilder();
     if (combinator is ShowElementCombinator) {
       b.shows = combinator.shownNames;
     } else if (combinator is HideElementCombinator) {
       b.hides = combinator.hiddenNames;
     }
@@ skipping 186 matching lines @@
       assert(unlinkedReferences.length == linkedReferences.length);
       int index = unlinkedReferences.length;
       unlinkedReferences.add(new UnlinkedReferenceBuilder(name: element.name));
       linkedReferences
           .add(new LinkedReferenceBuilder(kind: ReferenceKind.prefix));
       return index;
     });
   }
 
   /**
-   * If [cls] is a class, return the list of its public static methods and
-   * constructors.  Otherwise return `null`.
-   */
-  List<UnlinkedPublicNameBuilder> serializePublicStaticMethodsAndConstructors(
-      ClassElement cls) {
-    if (cls.kind == ElementKind.CLASS) {
-      List<UnlinkedPublicNameBuilder> bs = <UnlinkedPublicNameBuilder>[];
-      for (MethodElement method in cls.methods) {
-        if (method.isStatic && method.isPublic) {
-          bs.add(new UnlinkedPublicNameBuilder(
-              name: method.name,
-              kind: ReferenceKind.staticMethod,
-              numTypeParameters: method.typeParameters.length));
-        }
-      }
-      for (ConstructorElement constructor in cls.constructors) {
-        if (constructor.isPublic && !constructor.isSynthetic) {
-          bs.add(new UnlinkedPublicNameBuilder(
-              name: constructor.name,
-              kind: ReferenceKind.constructor,
-              numTypeParameters: 0));
-        }
-      }
-      return bs;
-    }
-    return null;
-  }
-
-  /**
    * Compute the reference index which should be stored in a [EntityRef].
    *
    * If [linked] is true, and a new reference has to be created, the reference
    * will only be stored in [linkedReferences].
    */
   int serializeReferenceForType(DartType type, bool linked) {
     Element element = type.element;
     LibraryElement dependentLibrary = element?.library;
     if (dependentLibrary == null) {
       assert(type.isDynamic || type.isVoid);
@@ skipping 433 matching lines @@
       exportNames.add(new LinkedExportNameBuilder(
           name: name,
           dependency: serializeDependency(dependentLibrary),
           unit: unit,
           kind: kind));
     }
     pb.exportNames = exportNames;
     return pb;
   }
 }