Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1924)

Unified Diff: Source/web/WebViewImpl.h

Issue 163933002: Send early ShowPress on TapDown when page isn't scrollable/pinchable. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add tests Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebViewImpl.h
diff --git a/Source/web/WebViewImpl.h b/Source/web/WebViewImpl.h
index 0bad5b6b6aa5d12339f4ebc568ae13b27817c46a..78876a17d9529edc280573cf8e8acb96f6c06856 100644
--- a/Source/web/WebViewImpl.h
+++ b/Source/web/WebViewImpl.h
@@ -531,6 +531,8 @@ public:
WebLayerTreeView* layerTreeView() const { return m_layerTreeView; }
+ bool isPinchZoomable() const;
+
private:
float legibleScale() const;
void refreshPageScaleFactorAfterLayout();
@@ -613,6 +615,8 @@ private:
void closeAndDeleteHelperPluginSoon(WebHelperPluginImpl*);
void closePendingHelperPlugins(WebCore::Timer<WebViewImpl>*);
+ bool shouldGestureTapDownTriggerActive(const WebCore::PlatformGestureEvent&);
Rick Byers 2014/02/21 03:35:52 Since this is no longer just about 'triggering act
Zeeshan Qureshi 2014/02/24 03:14:26 earlyGestureShowPress sounds good. I was using sho
+
WebCore::InputMethodContext* inputMethodContext();
WebPlugin* focusedPluginIfInputMethodSupported(WebCore::Frame*);
@@ -783,6 +787,8 @@ private:
WebCore::Timer<WebViewImpl> m_helperPluginCloseTimer;
Vector<WebHelperPluginImpl*> m_helperPluginsPendingClose;
+
+ bool m_gestureTapDownTriggeredActive;
Rick Byers 2014/02/21 03:35:52 maybe m_sentEarlyShowPress?
};
// We have no ways to check if the specified WebView is an instance of

Powered by Google App Engine
This is Rietveld 408576698