Send early ShowPress on TapDown when page isn't scrollable/pinchable.

Source/web/WebViewImpl.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 513 matching lines @@
     // Returns the bounding box of the block type node touched by the WebRect.
     WebRect computeBlockBounds(const WebRect&, bool ignoreClipping);
 
     WebCore::IntPoint clampOffsetAtScale(const WebCore::IntPoint& offset, float scale);
 
     // Exposed for tests.
     WebVector<WebCompositionUnderline> compositionUnderlines() const;
 
     WebLayerTreeView* layerTreeView() const { return m_layerTreeView; }
 
+    bool isPinchZoomable() const;
+
 private:
     float legibleScale() const;
     void refreshPageScaleFactorAfterLayout();
     void setUserAgentPageScaleConstraints(WebCore::PageScaleConstraints newConstraints);
     float clampPageScaleFactorToLimits(float) const;
     WebCore::IntSize contentsSize() const;
 
     void resetSavedScrollAndScaleState();
 
     void updateMainFrameScrollPosition(const WebCore::IntPoint& scrollPosition, bool programmaticScroll);
@@ skipping 62 matching lines @@
     virtual bool handleKeyEvent(const WebKeyboardEvent&) OVERRIDE;
     virtual bool handleCharEvent(const WebKeyboardEvent&) OVERRIDE;
 
     friend class WebHelperPluginImpl;
     // Take ownership of the Helper Plugin and destroy it asynchronously.
     // Called by WebHelperPluginImpl::closeAndDeleteSoon() to ensure the Helper
     // Plugin is closed at the correct time.
     void closeAndDeleteHelperPluginSoon(WebHelperPluginImpl*);
     void closePendingHelperPlugins(WebCore::Timer<WebViewImpl>*);
 
+    bool shouldGestureTapDownTriggerActive(const WebCore::PlatformGestureEvent&);

[Rick Byers, 2014/02/21 03:35:52]

Since this is no longer just about 'triggering active' (a concept WebViewImpl
doesn't even really know about), you should rename this.  Maybe something like
'shouldGestureTapDownTriggerShowPressImmediately', or less verbose
'earlyGestureShowPress'.

[Zeeshan Qureshi, 2014/02/24 03:14:26]

earlyGestureShowPress sounds good. I was using
shouldGestureTapDownTriggerShowPress earlier but switched to active. Thinking
about it, talking about ShowPress in WebView does make more sense, I'll add more
comments and update description accordingly.

+
     WebCore::InputMethodContext* inputMethodContext();
     WebPlugin* focusedPluginIfInputMethodSupported(WebCore::Frame*);
 
     WebViewClient* m_client; // Can be 0 (e.g. unittests, shared workers, etc.)
     WebAutofillClient* m_autofillClient;
     WebSpellCheckClient* m_spellCheckClient;
     WebPasswordGeneratorClient* m_passwordGeneratorClient;
 
     ChromeClientImpl m_chromeClientImpl;
     ContextMenuClientImpl m_contextMenuClientImpl;
@@ skipping 150 matching lines @@
     bool m_showPaintRects;
     bool m_showDebugBorders;
     bool m_continuousPaintingEnabled;
     bool m_showScrollBottleneckRects;
     WebColor m_baseBackgroundColor;
     WebColor m_backgroundColorOverride;
     float m_zoomFactorOverride;
 
     WebCore::Timer<WebViewImpl> m_helperPluginCloseTimer;
     Vector<WebHelperPluginImpl*> m_helperPluginsPendingClose;
+
+    bool m_gestureTapDownTriggeredActive;

[Rick Byers, 2014/02/21 03:35:52]

maybe m_sentEarlyShowPress?

 };
 
 // We have no ways to check if the specified WebView is an instance of
 // WebViewImpl because WebViewImpl is the only implementation of WebView.
 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true);
 
 } // namespace blink
 
 #endif