Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 1639293002: bluetooth: update bluetooth_dispatcher_host VLOG to BLUETOOTH_LOG (Closed)

Created:
4 years, 11 months ago by François Beaufort
Modified:
4 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@btDeviceLog
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: update bluetooth_dispatcher_host VLOG to BLUETOOTH_LOG BUG=516825

Patch Set 1 #

Total comments: 5

Patch Set 2 : Addressed ortuno's feedback #

Patch Set 3 : Removed gyp file update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -39 lines) Patch
M content/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/bluetooth/bluetooth_dispatcher_host.cc View 1 24 chunks +56 lines, -39 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (6 generated)
fbeaufortchromium
@ortuno please have a look ;)
4 years, 11 months ago (2016-01-27 14:24:25 UTC) #2
ortuno
These look good to me. Adding scheib since he might have some concerns. https://codereview.chromium.org/1639293002/diff/1/content/browser/bluetooth/bluetooth_dispatcher_host.cc File ...
4 years, 11 months ago (2016-01-27 19:15:36 UTC) #4
scheib
LGTM
4 years, 11 months ago (2016-01-27 21:52:01 UTC) #5
fbeaufortchromium
pfeldman@chromium.org: Please review changes in content/DEPS content/browser/BUILD.gn ortuno@chromium.org: I've addressed your feedback. https://codereview.chromium.org/1639293002/diff/1/content/browser/bluetooth/bluetooth_dispatcher_host.cc File content/browser/bluetooth/bluetooth_dispatcher_host.cc ...
4 years, 10 months ago (2016-01-28 08:46:52 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639293002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639293002/20001
4 years, 10 months ago (2016-01-28 08:49:15 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/139994)
4 years, 10 months ago (2016-01-28 08:58:57 UTC) #11
stevenjb
4 years, 10 months ago (2016-01-28 18:11:13 UTC) #13
not lgtm. Many of these seem like they could be much too spammy. Will discuss
more in email.

Powered by Google App Engine
This is Rietveld 408576698