bluetooth: Add Bluetooth events to chrome://device-log/

bluetooth: Add Bluetooth to chrome://device-log/

BUG=516825
Committed: https://crrev.com/bf5c71bb1b04209aefc7e562f0f0438d753a79c2
Cr-Commit-Position: refs/heads/master@{#371921}

[François Beaufort, 2016-01-14 12:09:20]

Description was changed from

==========
bluetooth: Add Bluetooth events to chrome://device-log/

BUG=516825
==========

to

==========
bluetooth: Add Bluetooth events to chrome://device-log/


Logic is:

VLOG(1) << __func__; -> BLUETOOTH_LOG(DEBUG) << __func__;
VLOG(1)              -> BLUETOOTH_LOG(EVENT)
VLOG(2)              -> BLUETOOTH_LOG(ERROR)

BUG=516825
==========

[François Beaufort, 2016-01-14 12:33:02]

Description was changed from

==========
bluetooth: Add Bluetooth events to chrome://device-log/


Logic is:

VLOG(1) << __func__; -> BLUETOOTH_LOG(DEBUG) << __func__;
VLOG(1)              -> BLUETOOTH_LOG(EVENT)
VLOG(2)              -> BLUETOOTH_LOG(ERROR)

BUG=516825
==========

to

==========
bluetooth: Add Bluetooth events to chrome://device-log/


Logic is:

VLOG(1) << __func__; -> BLUETOOTH_LOG(DEBUG) << __func__;
VLOG(1)              -> BLUETOOTH_LOG(EVENT)
VLOG(2)              -> BLUETOOTH_LOG(EVENT)

BLUETOOTH_LOG(EVENT) can also be replaced by BLUETOOTH_LOG(ERROR).

BUG=516825
==========

[stevenjb, 2016-01-19 21:54:58]

stevenjb@chromium.org changed reviewers:
+ stevenjb@chromium.org

[stevenjb, 2016-01-19 21:54:59]

https://codereview.chromium.org/1587723007/diff/60001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_adapter_bluez.cc (right):

https://codereview.chromium.org/1587723007/diff/60001/device/bluetooth/blueto...
device/bluetooth/bluetooth_adapter_bluez.cc:131: BLUETOOTH_LOG(EVENT) <<
"Unregistering pairing agent";
Let's separate out these events from this CL and start with a couple of
important ones, then we can examine which of these actually belong in the event
log separately.

[fbeaufortchromium, 2016-01-27 11:04:45]

Description was changed from

==========
bluetooth: Add Bluetooth events to chrome://device-log/


Logic is:

VLOG(1) << __func__; -> BLUETOOTH_LOG(DEBUG) << __func__;
VLOG(1)              -> BLUETOOTH_LOG(EVENT)
VLOG(2)              -> BLUETOOTH_LOG(EVENT)

BLUETOOTH_LOG(EVENT) can also be replaced by BLUETOOTH_LOG(ERROR).

BUG=516825
==========

to

==========
bluetooth: Add Bluetooth to chrome://device-log/

BUG=516825
==========

[fbeaufortchromium, 2016-01-27 11:05:50]

On 2016/01/19 21:54:59, stevenjb wrote:
>
https://codereview.chromium.org/1587723007/diff/60001/device/bluetooth/blueto...
> File device/bluetooth/bluetooth_adapter_bluez.cc (right):
> 
>
https://codereview.chromium.org/1587723007/diff/60001/device/bluetooth/blueto...
> device/bluetooth/bluetooth_adapter_bluez.cc:131: BLUETOOTH_LOG(EVENT) <<
> "Unregistering pairing agent";
> Let's separate out these events from this CL and start with a couple of
> important ones, then we can examine which of these actually belong in the
event
> log separately.

As suggested, I've removed events.
This CL is only about adding Bluetooth to about:device-log for now.

I will add proper Bluetooth events in separate CLs.

[fbeaufortchromium, 2016-01-27 12:47:04]

Patchset #5 (id:80001) has been deleted

[stevenjb, 2016-01-27 19:26:19]

I would have included some basic events like initialized / enabled / disabled,
but lgtm as-is.

[scheib, 2016-01-27 20:17:49]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2016-01-27 20:18:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1587723007/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1587723007/100001

[scheib, 2016-01-27 21:48:15]

LGTM

[commit-bot: I haz the power, 2016-01-28 00:17:52]

Description was changed from

==========
bluetooth: Add Bluetooth to chrome://device-log/

BUG=516825
==========

to

==========
bluetooth: Add Bluetooth to chrome://device-log/

BUG=516825
==========

[commit-bot: I haz the power, 2016-01-28 00:17:52]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-01-28 00:19:34]

Description was changed from

==========
bluetooth: Add Bluetooth to chrome://device-log/

BUG=516825
==========

to

==========
bluetooth: Add Bluetooth to chrome://device-log/

BUG=516825

Committed: https://crrev.com/bf5c71bb1b04209aefc7e562f0f0438d753a79c2
Cr-Commit-Position: refs/heads/master@{#371921}
==========

[commit-bot: I haz the power, 2016-01-28 00:19:35]

Patchset 5 (id:??) landed as
https://crrev.com/bf5c71bb1b04209aefc7e562f0f0438d753a79c2
Cr-Commit-Position: refs/heads/master@{#371921}