Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1639223003: Makes it so each windowtreeclient can use whatever ids it wants (Closed)

Created:
4 years, 11 months ago by sky
Modified:
4 years, 11 months ago
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes it so each windowtreeclient can use whatever ids it wants This way clients won't need to wait for OnEmbed() before they can start using windowtree. This also better isolates the apps. I haven't updated the client lib to take advantage of this. I will do that next. BUG=566155 TEST=covered by tests Committed: https://crrev.com/77009e2d52f6c4214f1616d2b4840abfa7de6eba Cr-Commit-Position: refs/heads/master@{#371915}

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+644 lines, -388 lines) Patch
M components/mus/ws/connection_manager.h View 2 chunks +5 lines, -5 lines 0 comments Download
M components/mus/ws/connection_manager.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M components/mus/ws/ids.h View 1 3 chunks +49 lines, -4 lines 0 comments Download
M components/mus/ws/server_window_surface.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/mus/ws/test_change_tracker.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M components/mus/ws/window_finder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/mus/ws/window_tree_apptest.cc View 37 chunks +160 lines, -91 lines 0 comments Download
M components/mus/ws/window_tree_host_impl.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M components/mus/ws/window_tree_host_impl.cc View 3 chunks +9 lines, -11 lines 0 comments Download
M components/mus/ws/window_tree_impl.h View 1 10 chunks +58 lines, -43 lines 0 comments Download
M components/mus/ws/window_tree_impl.cc View 1 47 chunks +248 lines, -160 lines 0 comments Download
M components/mus/ws/window_tree_unittest.cc View 12 chunks +97 lines, -65 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sky
4 years, 11 months ago (2016-01-27 21:30:21 UTC) #3
Ben Goodger (Google)
lgtm
4 years, 11 months ago (2016-01-27 23:49:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639223003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639223003/20001
4 years, 11 months ago (2016-01-27 23:51:52 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-28 00:13:39 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-28 00:15:04 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/77009e2d52f6c4214f1616d2b4840abfa7de6eba
Cr-Commit-Position: refs/heads/master@{#371915}

Powered by Google App Engine
This is Rietveld 408576698