Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1638953002: [DevTools] Migrate device-emulation tests from OverridesSupport to inspector-protocol. (Closed)

Created:
4 years, 11 months ago by dgozman
Modified:
4 years, 11 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Migrate device-emulation tests from OverridesSupport to inspector-protocol. BUG=540864 Committed: https://crrev.com/ecc795e9ed54e5f7e08891140aaf0b2ee8475b4c Cr-Commit-Position: refs/heads/master@{#371734}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -1717 lines) Patch
M third_party/WebKit/LayoutTests/NeverFixTests View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector-protocol/inspector-protocol-test.js View 2 chunks +17 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/protocol-test.html View 1 chunk +15 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-320.html View 1 chunk +1 line, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-320-2x.html View 1 chunk +1 line, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-320-2x-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-320-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-320-only-viewport.html View 1 chunk +1 line, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-320-only-viewport-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-980.html View 1 chunk +1 line, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-980-2x.html View 1 chunk +1 line, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-980-2x-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-980-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-980-only-viewport.html View 1 chunk +1 line, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-980-only-viewport-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-dw.html View 1 chunk +1 line, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-dw-2x.html View 1 chunk +1 line, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-dw-2x-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-dw-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-initial-scale.html View 1 chunk +1 line, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-initial-scale-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-insets.html View 2 chunks +2 lines, -3 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-insets-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-none.html View 1 chunk +1 line, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-none-2x.html View 1 chunk +1 line, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-none-2x-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-none-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-partial.html View 4 chunks +6 lines, -6 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-partial-expected.txt View 1 chunk +35 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-restore.html View 2 chunks +2 lines, -3 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-restore-expected.txt View 2 chunks +0 lines, -4 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-small.html View 1 chunk +1 line, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-small-dw.html View 1 chunk +1 line, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-small-dw-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-small-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-test.js View 6 chunks +30 lines, -31 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/device-emulation/device-emulation-320.html View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/device-emulation/device-emulation-320-2x.html View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/device-emulation/device-emulation-320-2x-expected.txt View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/device-emulation/device-emulation-320-expected.txt View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/device-emulation/device-emulation-320-only-viewport.html View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/device-emulation/device-emulation-320-only-viewport-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/device-emulation/device-emulation-980.html View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/device-emulation/device-emulation-980-2x.html View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/device-emulation/device-emulation-980-2x-expected.txt View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/device-emulation/device-emulation-980-expected.txt View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/device-emulation/device-emulation-980-only-viewport.html View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/device-emulation/device-emulation-980-only-viewport-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/device-emulation/device-emulation-dw.html View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/device-emulation/device-emulation-dw-2x.html View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/device-emulation/device-emulation-dw-2x-expected.txt View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/device-emulation/device-emulation-dw-expected.txt View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/device-emulation/device-emulation-initial-scale.html View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/device-emulation/device-emulation-initial-scale-expected.txt View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/device-emulation/device-emulation-insets.html View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/device-emulation/device-emulation-insets-expected.txt View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/device-emulation/device-emulation-none.html View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/device-emulation/device-emulation-none-2x.html View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/device-emulation/device-emulation-none-2x-expected.txt View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/device-emulation/device-emulation-none-expected.txt View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/device-emulation/device-emulation-partial.html View 1 chunk +0 lines, -138 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/device-emulation/device-emulation-partial-expected.txt View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/device-emulation/device-emulation-restore.html View 1 chunk +0 lines, -64 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/device-emulation/device-emulation-restore-expected.txt View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/device-emulation/device-emulation-small.html View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/device-emulation/device-emulation-small-dw.html View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/device-emulation/device-emulation-small-dw-expected.txt View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/device-emulation/device-emulation-small-expected.txt View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/device-emulation/device-emulation-test.js View 1 chunk +0 lines, -256 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dgozman
Take a look please.
4 years, 11 months ago (2016-01-26 19:45:22 UTC) #2
pfeldman
lgtm
4 years, 11 months ago (2016-01-27 02:56:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1638953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1638953002/1
4 years, 11 months ago (2016-01-27 04:21:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 05:09:38 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 05:10:55 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ecc795e9ed54e5f7e08891140aaf0b2ee8475b4c
Cr-Commit-Position: refs/heads/master@{#371734}

Powered by Google App Engine
This is Rietveld 408576698