[sqlite] Reenable deprecated methods on unix VFS.

[sqlite] Reenable deprecated methods on unix VFS.

In SQLite 3.10.2, the Unix VFS no longer defines unixCurrentTime(),
instead relying on unixCurrentTimeInt64().  The websql vfs wrapper
wraps at the v1 level, so expected to see xCurrentTime().

Backports http://www.sqlite.org/src/info/c11c85fdb6514cae

"Reenable the xCurrentTime and xGetLastError methods on the
unix VFSes as long as SQLITE_OMIT_DEPRECATED is not defined."

BUG=580948
TBR=michaeln@chromium.org

Committed: https://crrev.com/2be9709552db24566a960a33e0997775dea5cf0f
Cr-Commit-Position: refs/heads/master@{#371622}

[Scott Hess - ex-Googler, 2016-01-26 19:28:08]

My first pass was to modify chromium_vfs to implement chromiumCurrentTime() in
terms of the wrapped xCurrentTime() if present, otherwise xCurrentTimeInt64()
(based on os_win.c winCurrentTime() implementation).  Then I saw the SQLite
change in the timeline, and figured that would be cleaner.

https://codereview.chromium.org/1639863003 is a hacky "test" to prevent this
happening again.

[Scott Hess - ex-Googler, 2016-01-26 19:32:56]

On 2016/01/26 19:28:08, Scott Hess wrote:
> My first pass was to modify chromium_vfs to implement chromiumCurrentTime() in
> terms of the wrapped xCurrentTime() if present, otherwise xCurrentTimeInt64()
> (based on os_win.c winCurrentTime() implementation).  Then I saw the SQLite
> change in the timeline, and figured that would be cleaner.
> 
> https://codereview.chromium.org/1639863003 is a hacky "test" to prevent this
> happening again.

Running a split try job at https://codereview.chromium.org/1636873003

[Scott Hess - ex-Googler, 2016-01-26 21:35:47]

Description was changed from

==========
[sqlite] Reenable deprecated methods on unix VFS.

In SQLite 3.10.2, the Unix VFS no longer defines unixCurrentTime(),
instead relying on unixCurrentTimeInt64().  The websql vfs wrapper
wraps at the v1 level, so expected to see xCurrentTime().

Backports http://www.sqlite.org/src/info/c11c85fdb6514cae

"Reenable the xCurrentTime and xGetLastError methods on the
unix VFSes as long as SQLITE_OMIT_DEPRECATED is not defined."

BUG=580948
R=michaeln@chromium.org
==========

to

==========
[sqlite] Reenable deprecated methods on unix VFS.

In SQLite 3.10.2, the Unix VFS no longer defines unixCurrentTime(),
instead relying on unixCurrentTimeInt64().  The websql vfs wrapper
wraps at the v1 level, so expected to see xCurrentTime().

Backports http://www.sqlite.org/src/info/c11c85fdb6514cae

"Reenable the xCurrentTime and xGetLastError methods on the
unix VFSes as long as SQLITE_OMIT_DEPRECATED is not defined."

BUG=580948
TBR=michaeln@chromium.org
==========

[Scott Hess - ex-Googler, 2016-01-26 21:36:03]

On 2016/01/26 19:32:56, Scott Hess wrote:
> On 2016/01/26 19:28:08, Scott Hess wrote:
> > My first pass was to modify chromium_vfs to implement chromiumCurrentTime()
in
> > terms of the wrapped xCurrentTime() if present, otherwise
xCurrentTimeInt64()
> > (based on os_win.c winCurrentTime() implementation).  Then I saw the SQLite
> > change in the timeline, and figured that would be cleaner.
> > 
> > https://codereview.chromium.org/1639863003 is a hacky "test" to prevent this
> > happening again.
> 
> Running a split try job at https://codereview.chromium.org/1636873003

Landing TBR so that it makes tonight's canary.

[Scott Hess - ex-Googler, 2016-01-26 21:36:10]

The CQ bit was checked by shess@chromium.org

[commit-bot: I haz the power, 2016-01-26 21:37:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1638943002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1638943002/1

[michaeln, 2016-01-26 21:57:25]

lgtm

[commit-bot: I haz the power, 2016-01-26 22:42:41]

Description was changed from

==========
[sqlite] Reenable deprecated methods on unix VFS.

In SQLite 3.10.2, the Unix VFS no longer defines unixCurrentTime(),
instead relying on unixCurrentTimeInt64().  The websql vfs wrapper
wraps at the v1 level, so expected to see xCurrentTime().

Backports http://www.sqlite.org/src/info/c11c85fdb6514cae

"Reenable the xCurrentTime and xGetLastError methods on the
unix VFSes as long as SQLITE_OMIT_DEPRECATED is not defined."

BUG=580948
TBR=michaeln@chromium.org
==========

to

==========
[sqlite] Reenable deprecated methods on unix VFS.

In SQLite 3.10.2, the Unix VFS no longer defines unixCurrentTime(),
instead relying on unixCurrentTimeInt64().  The websql vfs wrapper
wraps at the v1 level, so expected to see xCurrentTime().

Backports http://www.sqlite.org/src/info/c11c85fdb6514cae

"Reenable the xCurrentTime and xGetLastError methods on the
unix VFSes as long as SQLITE_OMIT_DEPRECATED is not defined."

BUG=580948
TBR=michaeln@chromium.org
==========

[commit-bot: I haz the power, 2016-01-26 22:42:42]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-26 22:43:46]

Description was changed from

==========
[sqlite] Reenable deprecated methods on unix VFS.

In SQLite 3.10.2, the Unix VFS no longer defines unixCurrentTime(),
instead relying on unixCurrentTimeInt64().  The websql vfs wrapper
wraps at the v1 level, so expected to see xCurrentTime().

Backports http://www.sqlite.org/src/info/c11c85fdb6514cae

"Reenable the xCurrentTime and xGetLastError methods on the
unix VFSes as long as SQLITE_OMIT_DEPRECATED is not defined."

BUG=580948
TBR=michaeln@chromium.org
==========

to

==========
[sqlite] Reenable deprecated methods on unix VFS.

In SQLite 3.10.2, the Unix VFS no longer defines unixCurrentTime(),
instead relying on unixCurrentTimeInt64().  The websql vfs wrapper
wraps at the v1 level, so expected to see xCurrentTime().

Backports http://www.sqlite.org/src/info/c11c85fdb6514cae

"Reenable the xCurrentTime and xGetLastError methods on the
unix VFSes as long as SQLITE_OMIT_DEPRECATED is not defined."

BUG=580948
TBR=michaeln@chromium.org

Committed: https://crrev.com/2be9709552db24566a960a33e0997775dea5cf0f
Cr-Commit-Position: refs/heads/master@{#371622}
==========

[commit-bot: I haz the power, 2016-01-26 22:43:47]

Patchset 1 (id:??) landed as
https://crrev.com/2be9709552db24566a960a33e0997775dea5cf0f
Cr-Commit-Position: refs/heads/master@{#371622}