[websql] Guard against vfs method deprecation.

[websql] Guard against vfs method deprecation.

In SQLite 3.10.2, the Unix VFS no longer defines unixCurrentTime(),
instead relying on unixCurrentTimeInt64(), which caused a crash in the
implementation of chromiumCurrentTime().  Add assertions to verify
required infrastructure at instantiation rather than first use.

BUG=580948, 579743
R=michaeln@chromium.org

Committed: https://crrev.com/d67941884d3faf546e8fae1128ca131c777f5258
Cr-Commit-Position: refs/heads/master@{#371674}

[Scott Hess - ex-Googler, 2016-01-26 19:27:47]

Not necessary to fix the bug, but protects against it happening again.  Fixing
CL separately.

[michaeln, 2016-01-26 21:59:34]

https://codereview.chromium.org/1639863003/diff/1/third_party/WebKit/Source/m...
File
third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteFileSystemWin.cpp
(right):

https://codereview.chromium.org/1639863003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteFileSystemWin.cpp:161:
return SQLITE_ERROR;
What's going on with this function? Can you update the comment about it too.

[Scott Hess - ex-Googler, 2016-01-26 23:29:32]

Comment chromiumGetLastError.

[Scott Hess - ex-Googler, 2016-01-26 23:43:32]

Switch chromiumGetLastError to successfully return an empty buffer.

[Scott Hess - ex-Googler, 2016-01-26 23:44:24]

https://codereview.chromium.org/1639863003/diff/1/third_party/WebKit/Source/m...
File
third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteFileSystemWin.cpp
(right):

https://codereview.chromium.org/1639863003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteFileSystemWin.cpp:161:
return SQLITE_ERROR;
On 2016/01/26 21:59:34, michaeln wrote:
> What's going on with this function? Can you update the comment about it too.

OK.

SQLite introduced this at one point and then never used it, so it seemed safer
to fail safe rather than depend on the underlying VFS implementation.  The
current os_unix.c implementation returns 0 (SQLITE_OK) and says it is never
called (and it was removed entirely at the same time as unixGetCurrentTime).

Hmm.  Your question caused me to look over at the os_win.c implementation.  It
basically returns FormatMessage() results, though it's still never called.  The
docs there do indicate that returning 0 with an empty buffer is an appropriate
implementation.  So going with that.

[The online docs list xGetLastError with no description at all :-).]

[Scott Hess - ex-Googler, 2016-01-26 23:44:45]

The CQ bit was checked by shess@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-26 23:45:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1639863003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1639863003/40001

[Scott Hess - ex-Googler, 2016-01-26 23:45:46]

Description was changed from

==========
[websql] Guard against vfs method deprecation.

In SQLite 3.10.2, the Unix VFS no longer defines unixCurrentTime(),
instead relying on unixCurrentTimeInt64(), which caused a crash in the
implementation of chromiumCurrentTime().  Add assertions to verify
required infrastructure at instantiation rather than first use.

BUG=580948
R=michaeln@chromium.org
==========

to

==========
[websql] Guard against vfs method deprecation.

In SQLite 3.10.2, the Unix VFS no longer defines unixCurrentTime(),
instead relying on unixCurrentTimeInt64(), which caused a crash in the
implementation of chromiumCurrentTime().  Add assertions to verify
required infrastructure at instantiation rather than first use.

BUG=580948,579743
R=michaeln@chromium.org
==========

[michaeln, 2016-01-27 00:57:00]

thnx, lgtm

[commit-bot: I haz the power, 2016-01-27 01:07:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-27 01:07:37]

Dry run: This issue passed the CQ dry run.

[Scott Hess - ex-Googler, 2016-01-27 01:14:44]

The CQ bit was checked by shess@chromium.org

[Scott Hess - ex-Googler, 2016-01-27 01:14:52]

On 2016/01/27 00:57:00, michaeln wrote:
> thnx, lgtm

Thanks!

[commit-bot: I haz the power, 2016-01-27 01:15:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1639863003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1639863003/40001

[commit-bot: I haz the power, 2016-01-27 01:25:11]

Description was changed from

==========
[websql] Guard against vfs method deprecation.

In SQLite 3.10.2, the Unix VFS no longer defines unixCurrentTime(),
instead relying on unixCurrentTimeInt64(), which caused a crash in the
implementation of chromiumCurrentTime().  Add assertions to verify
required infrastructure at instantiation rather than first use.

BUG=580948,579743
R=michaeln@chromium.org
==========

to

==========
[websql] Guard against vfs method deprecation.

In SQLite 3.10.2, the Unix VFS no longer defines unixCurrentTime(),
instead relying on unixCurrentTimeInt64(), which caused a crash in the
implementation of chromiumCurrentTime().  Add assertions to verify
required infrastructure at instantiation rather than first use.

BUG=580948,579743
R=michaeln@chromium.org
==========

[commit-bot: I haz the power, 2016-01-27 01:25:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-27 01:26:32]

Description was changed from

==========
[websql] Guard against vfs method deprecation.

In SQLite 3.10.2, the Unix VFS no longer defines unixCurrentTime(),
instead relying on unixCurrentTimeInt64(), which caused a crash in the
implementation of chromiumCurrentTime().  Add assertions to verify
required infrastructure at instantiation rather than first use.

BUG=580948,579743
R=michaeln@chromium.org
==========

to

==========
[websql] Guard against vfs method deprecation.

In SQLite 3.10.2, the Unix VFS no longer defines unixCurrentTime(),
instead relying on unixCurrentTimeInt64(), which caused a crash in the
implementation of chromiumCurrentTime().  Add assertions to verify
required infrastructure at instantiation rather than first use.

BUG=580948,579743
R=michaeln@chromium.org

Committed: https://crrev.com/d67941884d3faf546e8fae1128ca131c777f5258
Cr-Commit-Position: refs/heads/master@{#371674}
==========

[commit-bot: I haz the power, 2016-01-27 01:26:33]

Patchset 3 (id:??) landed as
https://crrev.com/d67941884d3faf546e8fae1128ca131c777f5258
Cr-Commit-Position: refs/heads/master@{#371674}