Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1638723003: Add no-deprecated-declarations to ios_breakpad client (Closed)

Created:
4 years, 11 months ago by Olivier
Modified:
4 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add no-deprecated-declarations to ios_breakpad client Follow up on cl/1611283002. minidump_generator may be buit on by the breakpad_client target, which needs to allow the deprecated call. Will be removed after reland of https://codereview.chromium.org/1563223004/ BUG=579522, 569158 Committed: https://crrev.com/d09e077e5ea1b50752144a76768549a8aabfdaeb Cr-Commit-Position: refs/heads/master@{#371515}

Patch Set 1 #

Total comments: 3

Patch Set 2 : feedback #

Patch Set 3 : comment 2/2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M breakpad/breakpad.gyp View 1 2 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
Olivier
4 years, 11 months ago (2016-01-26 10:37:24 UTC) #2
sdefresne
lgtm but you also need an OWNERS of //breakpad.
4 years, 11 months ago (2016-01-26 10:38:47 UTC) #3
Olivier
+mark as owner
4 years, 11 months ago (2016-01-26 10:40:40 UTC) #5
blundell
lgtm +mento for OWNERS
4 years, 11 months ago (2016-01-26 10:40:45 UTC) #6
Olivier
+mark as owner
4 years, 11 months ago (2016-01-26 10:41:04 UTC) #7
Mark Mentovai
LGTM https://codereview.chromium.org/1638723003/diff/1/breakpad/breakpad.gyp File breakpad/breakpad.gyp (right): https://codereview.chromium.org/1638723003/diff/1/breakpad/breakpad.gyp#newcode876 breakpad/breakpad.gyp:876: # See https://bugs.chromium.org/p/google-breakpad/issues/detail?id=675. TODO(sdefresne): remove when fixed
4 years, 11 months ago (2016-01-26 14:03:08 UTC) #8
Mark Mentovai
https://codereview.chromium.org/1638723003/diff/1/breakpad/breakpad.gyp File breakpad/breakpad.gyp (right): https://codereview.chromium.org/1638723003/diff/1/breakpad/breakpad.gyp#newcode876 breakpad/breakpad.gyp:876: # See https://bugs.chromium.org/p/google-breakpad/issues/detail?id=675. Mark Mentovai wrote: > TODO(sdefresne): remove ...
4 years, 11 months ago (2016-01-26 14:06:52 UTC) #9
Olivier
I todoed on the bug, as it is the new format for bling.
4 years, 11 months ago (2016-01-26 14:08:34 UTC) #10
Olivier
https://codereview.chromium.org/1638723003/diff/1/breakpad/breakpad.gyp File breakpad/breakpad.gyp (right): https://codereview.chromium.org/1638723003/diff/1/breakpad/breakpad.gyp#newcode876 breakpad/breakpad.gyp:876: # See https://bugs.chromium.org/p/google-breakpad/issues/detail?id=675. On 2016/01/26 14:06:52, Mark Mentovai wrote: ...
4 years, 11 months ago (2016-01-26 14:10:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1638723003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1638723003/40001
4 years, 11 months ago (2016-01-26 14:10:26 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-26 15:28:17 UTC) #15
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 15:29:15 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d09e077e5ea1b50752144a76768549a8aabfdaeb
Cr-Commit-Position: refs/heads/master@{#371515}

Powered by Google App Engine
This is Rietveld 408576698