Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: tools/clang/rewrite_to_chrome_style/tests/constants-original.cc

Issue 1638683002: rewrite_to_chrome_style: Check expression is const when deciding style (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/rewrite_to_chrome_style/tests/constants-original.cc
diff --git a/tools/clang/rewrite_to_chrome_style/tests/constants-original.cc b/tools/clang/rewrite_to_chrome_style/tests/constants-original.cc
index e9e211260bd3ed6235bf67bee8db94e2c7b60984..96d974de77c17c011c785ee7a6f7813e20950ebe 100644
--- a/tools/clang/rewrite_to_chrome_style/tests/constants-original.cc
+++ b/tools/clang/rewrite_to_chrome_style/tests/constants-original.cc
@@ -25,6 +25,19 @@ class C {
// Not a constant even though it has static storage duration.
static const char* m_currentEvent;
+
+ static int Function();
+
+ static void FunctionWithConstant() {
+ const int kFunctionConstant = 4;
+ const int kFunctionConstantFromExpression = 4 + 6;
+ const int kFunctionConstantFromOtherConsts =
+ kFunctionConstant + kFunctionConstantFromExpression;
+ const int should_be_renamed_to_a_const = 9 - 2;
+ const int should_also_be_renamed_to_a_const =
+ kFunctionConstant + kFunctionConstantFromOtherConsts;
+ const int not_compile_time_const = kFunctionConstant + Function();
+ }
};
void F() {
« no previous file with comments | « tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698