Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc

Issue 1638683002: rewrite_to_chrome_style: Check expression is const when deciding style (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc
diff --git a/tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc b/tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc
index 0d02e9b8886dd13475851ba6ba6fc6b42b4f2236..e6b233babee959fa6ea443f9eb25862c0953de0d 100644
--- a/tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc
+++ b/tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc
@@ -25,6 +25,19 @@ class C {
// Not a constant even though it has static storage duration.
static const char* current_event_;
+
+ static int Function();
+
+ static void FunctionWithConstant() {
+ const int kFunctionConstant = 4;
+ const int kFunctionConstantFromExpression = 4 + 6;
+ const int kFunctionConstantFromOtherConsts =
+ kFunctionConstant + kFunctionConstantFromExpression;
+ const int kShouldBeRenamedToAConst = 9 - 2;
+ const int kShouldAlsoBeRenamedToAConst =
+ kFunctionConstant + kFunctionConstantFromOtherConsts;
+ const int not_compile_time_const = kFunctionConstant + Function();
+ }
};
void F() {

Powered by Google App Engine
This is Rietveld 408576698