rewrite_to_chrome_style: Check expression is const when deciding style

rewrite_to_chrome_style: Check expression is const when deciding style

For things labeled as "const", check if they can be compile-time
evaluated when deciding to name them kFooBar or foo_bar.

This fixes cases of const kFooBar = THING + OTHERTHING getting renamed
to k_foo_bar in blink.

Note that the tool is doing a slightly wrong thing when renaming a foo_bar
to a kFooBar, which we can fix separately (this adds some tests for it
that currently fail on that case).

R=dcheng
BUG=581185
Committed: https://crrev.com/92142e3e35d45e2a975b0b56114da4609602835c
Cr-Commit-Position: refs/heads/master@{#371370}

[danakj, 2016-01-25 23:46:40]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-25 23:48:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1638683002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1638683002/1

[danakj, 2016-01-25 23:50:39]

Description was changed from

==========
rewrite_to_chrome_style: Check expression is const when deciding style

For things labeled as "const", check if they can be compile-time
evaluated when deciding to name them kFooBar or foo_bar.

This fixes cases of const kFooBar = THING + OTHERTHING getting renamed
to k_foo_bar in blink.

Note that it's doing a slightly wrong thing when renaming a foo_bar
to a kFooBar, which we can fix separately (this adds some tests
demonstrating it though).

R=dcheng
BUG=581185
==========

to

==========
rewrite_to_chrome_style: Check expression is const when deciding style

For things labeled as "const", check if they can be compile-time
evaluated when deciding to name them kFooBar or foo_bar.

This fixes cases of const kFooBar = THING + OTHERTHING getting renamed
to k_foo_bar in blink.

Note that the tool is doing a slightly wrong thing when renaming a foo_bar
to a kFooBar, which we can fix separately (this adds some tests for it
that currently fail on that case).

R=dcheng
BUG=581185
==========

[dcheng, 2016-01-25 23:50:40]

lgtm

I should have looked harder originally.

[danakj, 2016-01-25 23:51:20]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2016-01-25 23:51:23]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-01-25 23:54:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1638683002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1638683002/1

[commit-bot: I haz the power, 2016-01-26 00:17:06]

Description was changed from

==========
rewrite_to_chrome_style: Check expression is const when deciding style

For things labeled as "const", check if they can be compile-time
evaluated when deciding to name them kFooBar or foo_bar.

This fixes cases of const kFooBar = THING + OTHERTHING getting renamed
to k_foo_bar in blink.

Note that the tool is doing a slightly wrong thing when renaming a foo_bar
to a kFooBar, which we can fix separately (this adds some tests for it
that currently fail on that case).

R=dcheng
BUG=581185
==========

to

==========
rewrite_to_chrome_style: Check expression is const when deciding style

For things labeled as "const", check if they can be compile-time
evaluated when deciding to name them kFooBar or foo_bar.

This fixes cases of const kFooBar = THING + OTHERTHING getting renamed
to k_foo_bar in blink.

Note that the tool is doing a slightly wrong thing when renaming a foo_bar
to a kFooBar, which we can fix separately (this adds some tests for it
that currently fail on that case).

R=dcheng
BUG=581185
==========

[commit-bot: I haz the power, 2016-01-26 00:17:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-26 00:20:03]

Description was changed from

==========
rewrite_to_chrome_style: Check expression is const when deciding style

For things labeled as "const", check if they can be compile-time
evaluated when deciding to name them kFooBar or foo_bar.

This fixes cases of const kFooBar = THING + OTHERTHING getting renamed
to k_foo_bar in blink.

Note that the tool is doing a slightly wrong thing when renaming a foo_bar
to a kFooBar, which we can fix separately (this adds some tests for it
that currently fail on that case).

R=dcheng
BUG=581185
==========

to

==========
rewrite_to_chrome_style: Check expression is const when deciding style

For things labeled as "const", check if they can be compile-time
evaluated when deciding to name them kFooBar or foo_bar.

This fixes cases of const kFooBar = THING + OTHERTHING getting renamed
to k_foo_bar in blink.

Note that the tool is doing a slightly wrong thing when renaming a foo_bar
to a kFooBar, which we can fix separately (this adds some tests for it
that currently fail on that case).

R=dcheng
BUG=581185

Committed: https://crrev.com/92142e3e35d45e2a975b0b56114da4609602835c
Cr-Commit-Position: refs/heads/master@{#371370}
==========

[commit-bot: I haz the power, 2016-01-26 00:20:04]

Patchset 1 (id:??) landed as
https://crrev.com/92142e3e35d45e2a975b0b56114da4609602835c
Cr-Commit-Position: refs/heads/master@{#371370}