Update references to tools/telemetry in .gn, .gyp & .isolate files

Update references to tools/telemetry in .gn, .gyp & .isolate files

Now that tools/telemetry is moved to catapult/ repo
(https://github.com/catapult-project/catapult/commit/40afc53353daf28b955397c8e27d6f1de7bb10b6), we will soon remove tools/telemetry/.

This patch update the reference to telemetry/ in .gn, .gyp & .isolate files

BUG=478864
TEST=patch set 1 delete telemetry/telemetry.gyp, telemetry/BUILD.gn & telemetry/telemetry.isolate, CQ shows that all bots are green.

Committed: https://crrev.com/c42bf9152ace37475c1149ec57ffe2838671085b
Cr-Commit-Position: refs/heads/master@{#371681}

[nednguyen, 2016-01-25 18:42:14]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-25 18:42:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1638483002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1638483002/1

[commit-bot: I haz the power, 2016-01-25 19:00:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-25 19:00:07]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nednguyen, 2016-01-26 02:38:55]

Patchset #3 (id:40001) has been deleted

[nednguyen, 2016-01-26 02:39:04]

Patchset #2 (id:20001) has been deleted

[nednguyen, 2016-01-26 02:39:12]

Patchset #1 (id:1) has been deleted

[nednguyen, 2016-01-26 03:23:08]

Patchset #3 (id:100001) has been deleted

[nednguyen, 2016-01-26 03:23:18]

Patchset #2 (id:80001) has been deleted

[nednguyen, 2016-01-26 03:23:25]

Patchset #1 (id:60001) has been deleted

[nednguyen, 2016-01-26 03:23:32]

Patchset #1 (id:120001) has been deleted

[nednguyen, 2016-01-26 22:11:01]

Description was changed from

==========
Remove tools/telemetry from isolates

BUG=
==========

to

==========
Update references to tools/telemetry in .gn, .gyp & .isolate files

Now that tools/telemetry is moved to catapult/ repo 
(https://github.com/catapult-project/catapult/commit/40afc53353daf28b955397c8e...),
we will soon remove tools/telemetry/. 

This patch update the reference to telemetry/ in .gn, .gyp & .isolate files
BUG=478864
==========

[nednguyen, 2016-01-26 22:15:50]

nednguyen@google.com changed reviewers:
+ aiolos@chromium.org, dpranke@chromium.org, kbr@chromium.org,
maruel@chromium.org, thakis@chromium.org

[nednguyen, 2016-01-26 22:16:09]

Patchset #1 (id:140001) has been deleted

[nednguyen, 2016-01-26 22:17:18]

Description was changed from

==========
Update references to tools/telemetry in .gn, .gyp & .isolate files

Now that tools/telemetry is moved to catapult/ repo 
(https://github.com/catapult-project/catapult/commit/40afc53353daf28b955397c8e...),
we will soon remove tools/telemetry/. 

This patch update the reference to telemetry/ in .gn, .gyp & .isolate files
BUG=478864
==========

to

==========
Update references to tools/telemetry in .gn, .gyp & .isolate files

Now that tools/telemetry is moved to catapult/ repo 
(https://github.com/catapult-project/catapult/commit/40afc53353daf28b955397c8e...),
we will soon remove tools/telemetry/. 

This patch update the reference to telemetry/ in .gn, .gyp & .isolate files

BUG=478864
TEST=patch set 1 delete telemetry/telemetry.gyp, telemetry/BUILD.gn &
telemetry/telemetry.isolate, CQ shows that all bots are green.
==========

[Dirk Pranke, 2016-01-26 22:23:17]

lgtm

[Nico, 2016-01-26 22:29:39]

https://codereview.chromium.org/1638483002/diff/180001/tools/perf/chrome_tele...
File tools/perf/chrome_telemetry_build/telemetry_chrome_test.isolate (right):

https://codereview.chromium.org/1638483002/diff/180001/tools/perf/chrome_tele...
tools/perf/chrome_telemetry_build/telemetry_chrome_test.isolate:16:
'../../../third_party/catapult/',
ident is wrong. Do you really need _all_ of that folder? How large is it?

[nednguyen, 2016-01-26 22:38:37]

https://codereview.chromium.org/1638483002/diff/180001/tools/perf/chrome_tele...
File tools/perf/chrome_telemetry_build/telemetry_chrome_test.isolate (right):

https://codereview.chromium.org/1638483002/diff/180001/tools/perf/chrome_tele...
tools/perf/chrome_telemetry_build/telemetry_chrome_test.isolate:16:
'../../../third_party/catapult/',
On 2016/01/26 22:29:39, Nico wrote:
> ident is wrong. Do you really need _all_ of that folder? How large is it?

https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/te...

Note that telemetry.isolate contains the whole catapult/, so this doesn't change
the size of the isolate.

I can make a subsequent work to try to shrink down the things that telemetry
needs, but it's an orthogonal issue.

[Nico, 2016-01-26 23:03:00]

Ok, lgtm with fixed indent then

On 2016/01/26 22:38:37, nednguyen wrote:
>
https://codereview.chromium.org/1638483002/diff/180001/tools/perf/chrome_tele...
> File tools/perf/chrome_telemetry_build/telemetry_chrome_test.isolate (right):
> 
>
https://codereview.chromium.org/1638483002/diff/180001/tools/perf/chrome_tele...
> tools/perf/chrome_telemetry_build/telemetry_chrome_test.isolate:16:
> '../../../third_party/catapult/',
> On 2016/01/26 22:29:39, Nico wrote:
> > ident is wrong. Do you really need _all_ of that folder? How large is it?
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/te...
> 
> Note that telemetry.isolate contains the whole catapult/, so this doesn't
change
> the size of the isolate.

At least it's an .isolate file already, so shrinking it down only requires
changing that file. After this CL, you'll need to create a .isolate file
upstream, wait for that to roll in, change this file to reference that new
isolate, and then shrink down.

[nednguyen, 2016-01-26 23:04:20]

On 2016/01/26 23:03:00, Nico wrote:
> Ok, lgtm with fixed indent then
> 
> On 2016/01/26 22:38:37, nednguyen wrote:
> >
>
https://codereview.chromium.org/1638483002/diff/180001/tools/perf/chrome_tele...
> > File tools/perf/chrome_telemetry_build/telemetry_chrome_test.isolate
(right):
> > 
> >
>
https://codereview.chromium.org/1638483002/diff/180001/tools/perf/chrome_tele...
> > tools/perf/chrome_telemetry_build/telemetry_chrome_test.isolate:16:
> > '../../../third_party/catapult/',
> > On 2016/01/26 22:29:39, Nico wrote:
> > > ident is wrong. Do you really need _all_ of that folder? How large is it?
> > 
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/te...
> > 
> > Note that telemetry.isolate contains the whole catapult/, so this doesn't
> change
> > the size of the isolate.
> 
> At least it's an .isolate file already, so shrinking it down only requires
> changing that file. After this CL, you'll need to create a .isolate file
> upstream, wait for that to roll in, change this file to reference that new
> isolate, and then shrink down.

The problem is the current telemetry.isolate is wrong, so I need to update it,
wait for the roll, then change this anyway.

[Ken Russell (switch to Gerrit), 2016-01-26 23:19:12]

https://codereview.chromium.org/1638483002/diff/180001/chrome/telemetry_gpu_u...
File chrome/telemetry_gpu_unittests.isolate (left):

https://codereview.chromium.org/1638483002/diff/180001/chrome/telemetry_gpu_u...
chrome/telemetry_gpu_unittests.isolate:6:
'../tools/telemetry/telemetry.isolate',
The removal of telemetry.isolate is unfortunate in my opinion. I would instead
suggest:

 -  moving it (not sure into which directory -- maybe content/)
 - updating all of these isolates who were depending on it to:
 -- update the path
 -- remove '../third_party/catapult' from their 'files' section instead.

[Ken Russell (switch to Gerrit), 2016-01-26 23:19:45]

btw, lgtm if this is really the direction you want to go.

[jam, 2016-01-26 23:46:04]

rubberstamp lgtm

[nednguyen, 2016-01-27 01:04:12]

On 2016/01/26 23:19:12, Ken Russell wrote:
>
https://codereview.chromium.org/1638483002/diff/180001/chrome/telemetry_gpu_u...
> File chrome/telemetry_gpu_unittests.isolate (left):
> 
>
https://codereview.chromium.org/1638483002/diff/180001/chrome/telemetry_gpu_u...
> chrome/telemetry_gpu_unittests.isolate:6:
> '../tools/telemetry/telemetry.isolate',
> The removal of telemetry.isolate is unfortunate in my opinion. I would instead
> suggest:
> 
>  -  moving it (not sure into which directory -- maybe content/)
>  - updating all of these isolates who were depending on it to:
>  -- update the path
>  -- remove '../third_party/catapult' from their 'files' section instead.

I also wish to do isolated testing for catapult CQ to ensure the dependency
boundary between projects. telemetry.isolate probably gonna come back at that
point, but I am ain't sure yet.

[nednguyen, 2016-01-27 01:04:27]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2016-01-27 01:04:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1638483002/#ps200001
(title: "Fix indent of
	tools/perf/chrome_telemetry_build/telemetry_chrome_test.isolate")

[commit-bot: I haz the power, 2016-01-27 01:08:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1638483002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1638483002/200001

[commit-bot: I haz the power, 2016-01-27 01:39:38]

Description was changed from

==========
Update references to tools/telemetry in .gn, .gyp & .isolate files

Now that tools/telemetry is moved to catapult/ repo 
(https://github.com/catapult-project/catapult/commit/40afc53353daf28b955397c8e...),
we will soon remove tools/telemetry/. 

This patch update the reference to telemetry/ in .gn, .gyp & .isolate files

BUG=478864
TEST=patch set 1 delete telemetry/telemetry.gyp, telemetry/BUILD.gn &
telemetry/telemetry.isolate, CQ shows that all bots are green.
==========

to

==========
Update references to tools/telemetry in .gn, .gyp & .isolate files

Now that tools/telemetry is moved to catapult/ repo 
(https://github.com/catapult-project/catapult/commit/40afc53353daf28b955397c8e...),
we will soon remove tools/telemetry/. 

This patch update the reference to telemetry/ in .gn, .gyp & .isolate files

BUG=478864
TEST=patch set 1 delete telemetry/telemetry.gyp, telemetry/BUILD.gn &
telemetry/telemetry.isolate, CQ shows that all bots are green.
==========

[commit-bot: I haz the power, 2016-01-27 01:39:39]

Committed patchset #3 (id:200001)

[commit-bot: I haz the power, 2016-01-27 01:41:03]

Description was changed from

==========
Update references to tools/telemetry in .gn, .gyp & .isolate files

Now that tools/telemetry is moved to catapult/ repo 
(https://github.com/catapult-project/catapult/commit/40afc53353daf28b955397c8e...),
we will soon remove tools/telemetry/. 

This patch update the reference to telemetry/ in .gn, .gyp & .isolate files

BUG=478864
TEST=patch set 1 delete telemetry/telemetry.gyp, telemetry/BUILD.gn &
telemetry/telemetry.isolate, CQ shows that all bots are green.
==========

to

==========
Update references to tools/telemetry in .gn, .gyp & .isolate files

Now that tools/telemetry is moved to catapult/ repo
(https://github.com/catapult-project/catapult/commit/40afc53353daf28b955397c8e...),
we will soon remove tools/telemetry/.

This patch update the reference to telemetry/ in .gn, .gyp & .isolate files

BUG=478864
TEST=patch set 1 delete telemetry/telemetry.gyp, telemetry/BUILD.gn &
telemetry/telemetry.isolate, CQ shows that all bots are green.

Committed: https://crrev.com/c42bf9152ace37475c1149ec57ffe2838671085b
Cr-Commit-Position: refs/heads/master@{#371681}
==========

[commit-bot: I haz the power, 2016-01-27 01:41:04]

Patchset 3 (id:??) landed as
https://crrev.com/c42bf9152ace37475c1149ec57ffe2838671085b
Cr-Commit-Position: refs/heads/master@{#371681}