Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3072)

Unified Diff: build/config/compiler/BUILD.gn

Issue 1638343003: Make unwind table inclusion configurable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 60954b3dcc064e606e2db5f8ed1ac909c60b413f..cf7a288fbbc917c49820119e2fe29311d81f694c 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -70,6 +70,10 @@ declare_args() {
# The patch is preapplied to the internal toolchain and hence all bots.
msvs_xtree_patched = false
}
+
+ # Omit unwind support in official builds to save space.
+ # We can use breakpad for these builds.
+ exclude_unwind_tables = is_chrome_branded && is_official_build
}
# Apply the default logic for these values if they were not set explicitly.
@@ -225,9 +229,7 @@ config("compiler") {
}
if (!is_nacl) {
- # Omit unwind support in official builds to save space.
- # We can use breakpad for these builds.
- if (is_chrome_branded && is_official_build) {
+ if (exclude_unwind_tables) {
cflags += [
"-fno-unwind-tables",
"-fno-asynchronous-unwind-tables",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698