Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 1638343003: Make unwind table inclusion configurable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/nacl/config.gni") 8 import("//build/config/nacl/config.gni")
9 import("//build/toolchain/ccache.gni") 9 import("//build/toolchain/ccache.gni")
10 10
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 # value expression until after its input values such as use_gold have 63 # value expression until after its input values such as use_gold have
64 # been set, e.g. by a toolchain_args() block. 64 # been set, e.g. by a toolchain_args() block.
65 use_debug_fission = "default" 65 use_debug_fission = "default"
66 66
67 if (is_win) { 67 if (is_win) {
68 # Whether the VS xtree header has been patched to disable warning 4702. If 68 # Whether the VS xtree header has been patched to disable warning 4702. If
69 # it has, then we don't need to disable 4702 (unreachable code warning). 69 # it has, then we don't need to disable 4702 (unreachable code warning).
70 # The patch is preapplied to the internal toolchain and hence all bots. 70 # The patch is preapplied to the internal toolchain and hence all bots.
71 msvs_xtree_patched = false 71 msvs_xtree_patched = false
72 } 72 }
73
74 # Omit unwind support in official builds to save space.
75 # We can use breakpad for these builds.
76 exclude_unwind_tables = is_chrome_branded && is_official_build
73 } 77 }
74 78
75 # Apply the default logic for these values if they were not set explicitly. 79 # Apply the default logic for these values if they were not set explicitly.
76 if (gold_path == false) { 80 if (gold_path == false) {
77 if (use_gold) { 81 if (use_gold) {
78 gold_path = rebase_path("//third_party/binutils/Linux_x64/Release/bin", 82 gold_path = rebase_path("//third_party/binutils/Linux_x64/Release/bin",
79 root_build_dir) 83 root_build_dir)
80 } else { 84 } else {
81 gold_path = "" 85 gold_path = ""
82 } 86 }
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
218 defines += [ "_FILE_OFFSET_BITS=64" ] 222 defines += [ "_FILE_OFFSET_BITS=64" ]
219 223
220 if (!is_android) { 224 if (!is_android) {
221 defines += [ 225 defines += [
222 "_LARGEFILE_SOURCE", 226 "_LARGEFILE_SOURCE",
223 "_LARGEFILE64_SOURCE", 227 "_LARGEFILE64_SOURCE",
224 ] 228 ]
225 } 229 }
226 230
227 if (!is_nacl) { 231 if (!is_nacl) {
228 # Omit unwind support in official builds to save space. 232 if (exclude_unwind_tables) {
229 # We can use breakpad for these builds.
230 if (is_chrome_branded && is_official_build) {
231 cflags += [ 233 cflags += [
232 "-fno-unwind-tables", 234 "-fno-unwind-tables",
233 "-fno-asynchronous-unwind-tables", 235 "-fno-asynchronous-unwind-tables",
234 ] 236 ]
235 defines += [ "NO_UNWIND_TABLES" ] 237 defines += [ "NO_UNWIND_TABLES" ]
236 } else { 238 } else {
237 cflags += [ "-funwind-tables" ] 239 cflags += [ "-funwind-tables" ]
238 } 240 }
239 } 241 }
240 } 242 }
(...skipping 1055 matching lines...) Expand 10 before | Expand all | Expand 10 after
1296 if (symbol_level == 0) { 1298 if (symbol_level == 0) {
1297 configs = [ ":no_symbols" ] 1299 configs = [ ":no_symbols" ]
1298 } else if (symbol_level == 1) { 1300 } else if (symbol_level == 1) {
1299 configs = [ ":minimal_symbols" ] 1301 configs = [ ":minimal_symbols" ]
1300 } else if (symbol_level == 2) { 1302 } else if (symbol_level == 2) {
1301 configs = [ ":symbols" ] 1303 configs = [ ":symbols" ]
1302 } else { 1304 } else {
1303 assert(false) 1305 assert(false)
1304 } 1306 }
1305 } 1307 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698