Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1638333002: ObjectLiterals in full code went to the runtime unnecessarily. (Closed)

Created:
4 years, 11 months ago by mvstanton
Modified:
4 years, 11 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ObjectLiterals in full code went to the runtime unnecessarily. BUG= R=mstarzinger@chromium.org Committed: https://crrev.com/95cb4e04291bdbdb7d1e45a3a40059f03ed52e03 Cr-Commit-Position: refs/heads/master@{#33546}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/full-codegen/full-codegen.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mvstanton
Hi Michael, Here is this rather silly bug I found. Thx for the look, --Mike
4 years, 11 months ago (2016-01-27 11:51:57 UTC) #1
Michael Starzinger
LGTM. Nice catch! As discussed offline, we need to watch out for kDisableMementos here. This ...
4 years, 11 months ago (2016-01-27 12:20:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1638333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1638333002/1
4 years, 11 months ago (2016-01-27 12:23:18 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 12:29:29 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 12:29:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/95cb4e04291bdbdb7d1e45a3a40059f03ed52e03
Cr-Commit-Position: refs/heads/master@{#33546}

Powered by Google App Engine
This is Rietveld 408576698