Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: src/full-codegen/full-codegen.cc

Issue 1638333002: ObjectLiterals in full code went to the runtime unnecessarily. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/full-codegen/full-codegen.cc
diff --git a/src/full-codegen/full-codegen.cc b/src/full-codegen/full-codegen.cc
index 5e2338c2b8d4b214e2fa0afa4eb312469a7ea3be..2edb9c6bd94bbce59600ba32001710dedb5cce0d 100644
--- a/src/full-codegen/full-codegen.cc
+++ b/src/full-codegen/full-codegen.cc
@@ -148,8 +148,8 @@ bool FullCodeGenerator::MustCreateObjectLiteralWithRuntime(
// support copy-on-write (COW) elements for now.
// TODO(mvstanton): make object literals support COW elements.
return masm()->serializer_enabled() ||
- literal_flags != ObjectLiteral::kShallowProperties ||
- literal_flags != ObjectLiteral::kFastElements ||
+ (literal_flags & ObjectLiteral::kShallowProperties) == 0 ||
+ (literal_flags & ObjectLiteral::kFastElements) == 0 ||
expr->properties_count() >
FastCloneShallowObjectStub::kMaximumClonedProperties;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698