src/codec/SkRawCodec.cpp - Issue 1638323002: Filx complier issue [-Werror, -Wvla]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codec/SkRawCodec.cpp

Issue 1638323002: Filx complier issue [-Werror, -Wvla] (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Put stuff on the heap unconditionally Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/codec/SkRawCodec.cpp

diff --git a/src/codec/SkRawCodec.cpp b/src/codec/SkRawCodec.cpp

index 05f18ac635918d448149fe112374ebd57636789c..79590d18324805add915f18ed9c80c1b7162838c 100644

--- a/src/codec/SkRawCodec.cpp

+++ b/src/codec/SkRawCodec.cpp

@@ -405,7 +405,7 @@ SkCodec::Result SkRawCodec::onGetPixels(const SkImageInfo& requestedInfo, void*

}

void* dstRow = dst;

- uint8_t srcRow[width * 3];

+ SkAutoTMalloc<uint8_t> srcRow(width * 3);

dng_pixel_buffer buffer;

buffer.fData = &srcRow[0];

« no previous file with comments | « no previous file | no next file » | no next file with comments »