Filx complier issue [-Werror, -Wvla]

src/codec/SkRawCodec.cpp

 /*
  * Copyright 2016 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkCodec.h"
 #include "SkCodecPriv.h"
 #include "SkColorPriv.h"
@@ skipping 387 matching lines @@
     // Because the DNG SDK can not guarantee to render to requested size, we allow a small
     // difference. Only the overlapping region will be converted.
     const float maxDiffRatio = 1.03f;
     const dng_point& imageSize = image->Size();
     if (imageSize.h / width > maxDiffRatio || imageSize.h < width ||
         imageSize.v / height > maxDiffRatio || imageSize.v < height) {
         return SkCodec::kInvalidScale;
     }
 
     void* dstRow = dst;
-    uint8_t srcRow[width * 3];
+    SkAutoTMalloc<uint8_t> srcRow(width * 3);
 
     dng_pixel_buffer buffer;
     buffer.fData = &srcRow[0];
     buffer.fPlane = 0;
     buffer.fPlanes = 3;
     buffer.fColStep = buffer.fPlanes;
     buffer.fPlaneStep = 1;
     buffer.fPixelType = ttByte;
     buffer.fPixelSize = sizeof(uint8_t);
     buffer.fRowStep = sizeof(srcRow);

[dogben, 2016/01/29 19:36:08]

Does this really work?

[mtklein, 2016/01/29 19:47:48]

Nope, it's quite wrong.  If the old VLA code was correct, this should now read
width*3.

[scroggo, 2016/01/29 20:44:29]

Agreed. Is someone already fixing this?

[scroggo, 2016/01/29 21:01:30]

I've posted a fix at crrev.com/1643373002.

How did it work before though? Gold looks to have some valid results, when it
should never be right. 

 
     for (int i = 0; i < height; ++i) {
         buffer.fArea = dng_rect(i, 0, i + 1, width);
 
         try {
             image->Get(buffer, dng_image::edge_zero);
         } catch (...) {
             *rowsDecoded = i;
             return kIncompleteInput; 
         }
@@ skipping 37 matching lines @@
     SkISize sizeFloor = this->onGetScaledDimensions(1.f / std::floor(fullShortEdge / shortEdge));
     SkISize sizeCeil = this->onGetScaledDimensions(1.f / std::ceil(fullShortEdge / shortEdge));
     return sizeFloor == dim || sizeCeil == dim;
 }
 
 SkRawCodec::~SkRawCodec() {}
 
 SkRawCodec::SkRawCodec(SkDngImage* dngImage)
     : INHERITED(dngImage->getImageInfo(), nullptr)
     , fDngImage(dngImage) {}