Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1638313003: Add support for ubuntu 15.10(wily) to install-build-deps.sh (Closed)

Created:
4 years, 11 months ago by haltonhuo
Modified:
4 years, 10 months ago
Reviewers:
jamesr, Dirk Pranke
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Allow install-build-deps.sh run on ubuntu 15.10(wily) Also remove some unnessesary packages: xfonts-mathml, apache2.2-bin BUG= R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/4ca9a43c3bfab967ed6a55fd74aad3ffd7b647f9

Patch Set 1 #

Patch Set 2 : Fix for Jamesr's comment #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M build/install-build-deps.sh View 1 4 chunks +3 lines, -4 lines 2 comments Download

Messages

Total messages: 17 (4 generated)
haltonhuo
dpranke, this CL is almost exact same as https://codereview.chromium.org/1580663002, but different for mojo git repo. ...
4 years, 11 months ago (2016-01-27 10:07:24 UTC) #2
haltonhuo
On 2016/01/27 10:07:24, haltonhuo wrote: > dpranke, this CL is almost exact same as > ...
4 years, 11 months ago (2016-01-27 10:08:43 UTC) #3
Dirk Pranke
This looks fine to me, but I don't really commit stuff in mojo these days, ...
4 years, 11 months ago (2016-01-27 17:57:07 UTC) #5
jamesr
I think we only want to support Ubuntu LTS releases in Mojo, unless there's some ...
4 years, 11 months ago (2016-01-27 18:41:23 UTC) #6
haltonhuo
On 2016/01/27 18:41:23, jamesr wrote: > I think we only want to support Ubuntu LTS ...
4 years, 11 months ago (2016-01-28 01:33:39 UTC) #7
jamesr
We shouldn't need xfonts or apache at all. Maybe a better first step would be ...
4 years, 11 months ago (2016-01-28 01:41:39 UTC) #8
haltonhuo
On 2016/01/28 01:41:39, jamesr wrote: > We shouldn't need xfonts or apache at all. Maybe ...
4 years, 11 months ago (2016-01-28 01:45:52 UTC) #9
jamesr
Just the parts you're changing is fine. I think it'd be OK to change the ...
4 years, 11 months ago (2016-01-28 01:47:19 UTC) #10
haltonhuo
On 2016/01/28 01:47:19, jamesr wrote: > Just the parts you're changing is fine. I think ...
4 years, 11 months ago (2016-01-28 02:20:01 UTC) #12
haltonhuo
https://codereview.chromium.org/1638313003/diff/20001/build/install-build-deps.sh File build/install-build-deps.sh (left): https://codereview.chromium.org/1638313003/diff/20001/build/install-build-deps.sh#oldcode223 build/install-build-deps.sh:223: Woops, this deletion is not in purpose. But removing ...
4 years, 11 months ago (2016-01-28 02:22:50 UTC) #13
jamesr
lgtm https://codereview.chromium.org/1638313003/diff/20001/build/install-build-deps.sh File build/install-build-deps.sh (left): https://codereview.chromium.org/1638313003/diff/20001/build/install-build-deps.sh#oldcode223 build/install-build-deps.sh:223: On 2016/01/28 at 02:22:50, haltonhuo wrote: > Woops, ...
4 years, 10 months ago (2016-01-28 20:21:58 UTC) #14
haltonhuo
On 2016/01/28 20:21:58, jamesr wrote: > lgtm jamesr, the page shows me "Project "mojo" does ...
4 years, 10 months ago (2016-01-29 02:22:17 UTC) #15
jamesr
4 years, 10 months ago (2016-02-01 18:58:54 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4ca9a43c3bfab967ed6a55fd74aad3ffd7b647f9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698