|
|
Chromium Code Reviews
DescriptionAllow install-build-deps.sh run on ubuntu 15.10(wily)
Also remove some unnessesary packages: xfonts-mathml, apache2.2-bin
BUG=
R=jamesr@chromium.org
Committed: https://chromium.googlesource.com/external/mojo/+/4ca9a43c3bfab967ed6a55fd74aad3ffd7b647f9
Patch Set 1 #Patch Set 2 : Fix for Jamesr's comment #
Total comments: 2
Messages
Total messages: 17 (4 generated)
halton.huo@intel.com changed reviewers: + dpranke@chromium.org
dpranke, this CL is almost exact same as https://codereview.chromium.org/1580663002, but different for mojo git repo. PTAL
On 2016/01/27 10:07:24, haltonhuo wrote: > dpranke, this CL is almost exact same as > https://codereview.chromium.org/1580663002, but different for mojo git repo. > PTAL BTW, when I runt git cl upload, I met warnings and "git cl try" errors, no idea it is related or not. $ git cl upload -v Using 50% similarity for rename/copy detection. Override with --similarity. INFO:third_party.oauth2client.client:access_token is expired. Now: 2016-01-27 09:59:57.376154, token_expiry: 2016-01-20 12:32:33 Running presubmit upload checks ... Running /home/halton/work/projects/github/mojo/git/src/PRESUBMIT.py Running /home/halton/work/projects/github/mojo/git/src/build/PRESUBMIT.py ** Presubmit Warnings ** Out of 115 files, found none that matched w=['.+_test.py$'], b=None in directory . There were presubmit warnings. Are you sure you wish to continue? (y/N): y build/install-build-deps.sh | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) INFO:root:upload.RealMain(['upload', '--assume_yes', '--server', 'https://codereview.chromium.org', '--message', u'Add support for ubuntu 15.10(wily) to install-build-deps.sh\n\nUse new package names on 15.10 conditionally:\n apache2.2-bin -> apacahe2-bin\n xfonts-mathml -> fonts-stix\n\nBUG=', '--cc', 'mojo-reviews@chromium.org', '--git_similarity', '50', '--base_url', 'https://github.com/domokit/mojo.git@master', '--target_ref', 'refs/heads/master', '--project', 'mojo', '133a395d155f6bb7158be5f597832da7cbf57717', 'HEAD']) Upload server: https://codereview.chromium.org (change with -s/--server) INFO:third_party.oauth2client.client:access_token is expired. Now: 2016-01-27 10:00:16.550036, token_expiry: 2016-01-20 12:32:33 INFO:third_party.oauth2client.client:access_token is expired. Now: 2016-01-27 10:00:16.550179, token_expiry: 2016-01-20 12:32:33 INFO:third_party.oauth2client.client:access_token is expired. Now: 2016-01-27 10:00:16.550446, token_expiry: 2016-01-20 12:32:33 INFO:third_party.oauth2client.client:access_token is expired. Now: 2016-01-27 10:00:16.550534, token_expiry: 2016-01-20 12:32:33 INFO:third_party.oauth2client.client:access_token is expired. Now: 2016-01-27 10:00:16.550794, token_expiry: 2016-01-20 12:32:33 INFO:third_party.oauth2client.client:Refreshing access_token INFO:root:OAuth access_token refreshed. Expires in 0:59:59.999221. Issue created. URL: https://codereview.chromium.org/1638313003 Uploading base file for build/install-build-deps.sh Running /home/halton/work/projects/github/mojo/git/src/build/PRESUBMIT.py Running /home/halton/work/projects/github/mojo/git/src/PRESUBMIT.py ERROR: Error in response. Code: 403. Reason: . Message: Forbidden. Traceback (most recent call last): File "/home/halton/work/projects/chromium/depot_tools/git_cl.py", line 3719, in <module> sys.exit(main(sys.argv[1:])) File "/home/halton/work/projects/chromium/depot_tools/git_cl.py", line 3701, in main return dispatcher.execute(OptionParser(), argv) File "/home/halton/work/projects/chromium/depot_tools/subcommand.py", line 252, in execute return command(parser, args[1:]) File "/home/halton/work/projects/chromium/depot_tools/git_cl.py", line 2483, in CMDupload sys.stdout) File "/home/halton/work/projects/chromium/depot_tools/presubmit_support.py", line 1336, in DoPostUploadExecuter presubmit_script, filename, cl, change)) File "/home/halton/work/projects/chromium/depot_tools/presubmit_support.py", line 1181, in ExecPresubmitScript return post_upload_hook(cl, change, OutputApi(False)) File "<string>", line 1134, in PostUploadHook File "/usr/lib/python2.7/subprocess.py", line 540, in check_call raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command '['git', 'cl', 'try']' returned non-zero exit status 1
dpranke@chromium.org changed reviewers: + jamesr@chromium.org
This looks fine to me, but I don't really commit stuff in mojo these days, so you should probably get an active mojo contributor to review it as well. James, maybe?
I think we only want to support Ubuntu LTS releases in Mojo, unless there's some really compelling reason to support others. Is there something in Wily you really need?
On 2016/01/27 18:41:23, jamesr wrote: > I think we only want to support Ubuntu LTS releases in Mojo, unless there's some > really compelling reason to support others. Is there something in Wily you > really need? Jamesr, thanks for your reviewing. No special need on Wily actually, but I happened to upgrade my Ubuntu to Wily and meet the problem. So I upload CL to chromium, and when I try Mojo build, I have same error so here come this CL.
We shouldn't need xfonts or apache at all. Maybe a better first step would be to trim this list down to only packages that are actually needed for mojo development (instead of everything for chromium).
On 2016/01/28 01:41:39, jamesr wrote: > We shouldn't need xfonts or apache at all. Maybe a better first step would be > to trim this list down to only packages that are actually needed for mojo > development (instead of everything for chromium). So I'll update CL to remove those two packages. Or you want me to do a cleanup for unnecessary pkgs? That would need more time to read the code and test a clean Ubuntu.
Just the parts you're changing is fine. I think it'd be OK to change the check, but don't print out that Wily is supported. It is not and will not be - we're only going to worry about whether LTSes work (and then in practice only the most recent ones).
Description was changed from
==========
Add support for ubuntu 15.10(wily) to install-build-deps.sh
Use new package names on 15.10 conditionally:
apache2.2-bin -> apacahe2-bin
xfonts-mathml -> fonts-stix
BUG=
==========
to
==========
Allow install-build-deps.sh run on ubuntu 15.10(wily)
Also remove some unnessesary packages: xfonts-mathml, apache2.2-bin
BUG=
==========
On 2016/01/28 01:47:19, jamesr wrote: > Just the parts you're changing is fine. I think it'd be OK to change the check, > but don't print out that Wily is supported. It is not and will not be - we're > only going to worry about whether LTSes work (and then in practice only the most > recent ones). Jamesr, patch set2 uploaded, please take another look
https://codereview.chromium.org/1638313003/diff/20001/build/install-build-dep... File build/install-build-deps.sh (left): https://codereview.chromium.org/1638313003/diff/20001/build/install-build-dep... build/install-build-deps.sh:223: Woops, this deletion is not in purpose. But removing it seems no harm and follow one empty line as other places. Should I revert this?
lgtm https://codereview.chromium.org/1638313003/diff/20001/build/install-build-dep... File build/install-build-deps.sh (left): https://codereview.chromium.org/1638313003/diff/20001/build/install-build-dep... build/install-build-deps.sh:223: On 2016/01/28 at 02:22:50, haltonhuo wrote: > Woops, this deletion is not in purpose. But removing it seems no harm and follow one empty line as other places. Should I revert this? This is fine
On 2016/01/28 20:21:58, jamesr wrote: > lgtm jamesr, the page shows me "Project "mojo" does not have a commit queue”, could you help me to land?
Description was changed from
==========
Allow install-build-deps.sh run on ubuntu 15.10(wily)
Also remove some unnessesary packages: xfonts-mathml, apache2.2-bin
BUG=
==========
to
==========
Allow install-build-deps.sh run on ubuntu 15.10(wily)
Also remove some unnessesary packages: xfonts-mathml, apache2.2-bin
BUG=
R=jamesr@chromium.org
Committed:
https://chromium.googlesource.com/external/mojo/+/4ca9a43c3bfab967ed6a55fd74a...
==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 4ca9a43c3bfab967ed6a55fd74aad3ffd7b647f9 (presubmit successful). |
