Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1638283004: [wasm] Backoff implementation for F64Trunc using std::trunc. (Closed)

Created:
4 years, 10 months ago by ahaas
Modified:
4 years, 10 months ago
Reviewers:
titzer, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@init-root-register
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Backoff implementation for F64Trunc using std::trunc. R=titzer@chromium.org Committed: https://crrev.com/3f4163cd2410586d20b00348e8d326e4ada88452 Cr-Commit-Position: refs/heads/master@{#33670}

Patch Set 1 #

Patch Set 2 : Initialize the root register only on x64 #

Patch Set 3 : rebase #

Patch Set 4 : Use math.h trunc instead of std::trunc. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -15 lines) Patch
M src/assembler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/assembler.cc View 1 2 3 2 chunks +7 lines, -0 lines 1 comment Download
M src/compiler/wasm-compiler.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 1 2 2 chunks +57 lines, -7 lines 0 comments Download
M src/compiler/wasm-linkage.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/snapshot/serialize.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 1 2 2 chunks +6 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (3 generated)
ahaas
4 years, 10 months ago (2016-01-28 19:24:22 UTC) #1
Yang
On 2016/01/28 19:24:22, ahaas wrote: serializer lgtm.
4 years, 10 months ago (2016-01-28 19:28:14 UTC) #2
ahaas
https://codereview.chromium.org/1638283004/diff/60001/src/assembler.cc File src/assembler.cc (right): https://codereview.chromium.org/1638283004/diff/60001/src/assembler.cc#newcode1135 src/assembler.cc:1135: static void trunc64_wrapper(double* param) { *param = trunc(*param); } ...
4 years, 10 months ago (2016-02-01 12:04:02 UTC) #3
titzer
On 2016/02/01 12:04:02, ahaas wrote: > https://codereview.chromium.org/1638283004/diff/60001/src/assembler.cc > File src/assembler.cc (right): > > https://codereview.chromium.org/1638283004/diff/60001/src/assembler.cc#newcode1135 > ...
4 years, 10 months ago (2016-02-02 10:22:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1638283004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1638283004/60001
4 years, 10 months ago (2016-02-02 10:55:54 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-02-02 10:58:07 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 11:04:10 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3f4163cd2410586d20b00348e8d326e4ada88452
Cr-Commit-Position: refs/heads/master@{#33670}

Powered by Google App Engine
This is Rietveld 408576698