Change PC for OSR entries to point to something more sensible (i.e. the first UnknownOsrValue), rem…

Change PC for OSR entries to point to something more sensible (i.e. the first UnknownOsrValue), removing the need to record spilled OSR values and the need for duplicate deopt entries.

Committed: https://code.google.com/p/v8/source/detail?r=15331

[Michael Starzinger, 2013-06-11 17:24:06]

https://codereview.chromium.org/16381006/diff/1/src/deoptimizer.cc
File src/deoptimizer.cc (left):

https://codereview.chromium.org/16381006/diff/1/src/deoptimizer.cc#oldcode1736
src/deoptimizer.cc:1736: UNREACHABLE();
Don't remove the unreachable assertion, other cases fall-through here.

https://codereview.chromium.org/16381006/diff/1/src/deoptimizer.cc#oldcode2015
src/deoptimizer.cc:2015: UNREACHABLE();  // Malformed input.
Don't remove the unreachable assertion, other cases fall-through here.

https://codereview.chromium.org/16381006/diff/1/src/lithium-allocator.cc
File src/lithium-allocator.cc (left):

https://codereview.chromium.org/16381006/diff/1/src/lithium-allocator.cc#oldc...
src/lithium-allocator.cc:1467: void LAllocator::ProcessOsrEntry() {
Also remove the declaration of this method in the lithium-allocator.h file.

[Michael Starzinger, 2013-06-11 18:45:01]

Can we flip the name of the test cases so that they all have a commmon prefix,
makes them easier to find. I was thinking along the lines of "osr-nested",
"osr-big", "osr-simple-with-args" and so on.

[titzer, 2013-06-12 09:30:04]

https://codereview.chromium.org/16381006/diff/1/src/deoptimizer.cc
File src/deoptimizer.cc (left):

https://codereview.chromium.org/16381006/diff/1/src/deoptimizer.cc#oldcode1736
src/deoptimizer.cc:1736: UNREACHABLE();
On 2013/06/11 17:24:07, Michael Starzinger wrote:
> Don't remove the unreachable assertion, other cases fall-through here.

Done.

https://codereview.chromium.org/16381006/diff/1/src/deoptimizer.cc#oldcode2015
src/deoptimizer.cc:2015: UNREACHABLE();  // Malformed input.
On 2013/06/11 17:24:07, Michael Starzinger wrote:
> Don't remove the unreachable assertion, other cases fall-through here.

Done.

https://codereview.chromium.org/16381006/diff/1/src/lithium-allocator.cc
File src/lithium-allocator.cc (left):

https://codereview.chromium.org/16381006/diff/1/src/lithium-allocator.cc#oldc...
src/lithium-allocator.cc:1467: void LAllocator::ProcessOsrEntry() {
On 2013/06/11 17:24:07, Michael Starzinger wrote:
> Also remove the declaration of this method in the lithium-allocator.h file.

Done.

[Michael Starzinger, 2013-06-12 09:36:42]

LGTM. Nice simplification.

[titzer, 2013-06-26 08:43:50]

Committed patchset #4 manually as r15331 (presubmit successful).