Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1637973002: Vectorize menu radio buttons. (Closed)

Created:
4 years, 11 months ago by Evan Stade
Modified:
4 years, 11 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Vectorize menu radio buttons. BUG=561133 TEST=on cros, right click on shelf > shelf position Committed: https://crrev.com/53cd62240b689e5fd8876580fff33a06c866928f Cr-Commit-Position: refs/heads/master@{#371948}

Patch Set 1 #

Total comments: 2

Messages

Total messages: 13 (5 generated)
Evan Stade
4 years, 11 months ago (2016-01-26 19:40:21 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637973002/1
4 years, 11 months ago (2016-01-26 19:41:58 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-26 20:38:13 UTC) #6
sadrul
lgtm https://codereview.chromium.org/1637973002/diff/1/ui/views/controls/menu/menu_image_util.h File ui/views/controls/menu/menu_image_util.h (right): https://codereview.chromium.org/1637973002/diff/1/ui/views/controls/menu/menu_image_util.h#newcode21 ui/views/controls/menu/menu_image_util.h:21: // the radio option is active, |hovered| describes ...
4 years, 11 months ago (2016-01-26 21:59:30 UTC) #7
Evan Stade
https://codereview.chromium.org/1637973002/diff/1/ui/views/controls/menu/menu_image_util.h File ui/views/controls/menu/menu_image_util.h (right): https://codereview.chromium.org/1637973002/diff/1/ui/views/controls/menu/menu_image_util.h#newcode21 ui/views/controls/menu/menu_image_util.h:21: // the radio option is active, |hovered| describes the ...
4 years, 11 months ago (2016-01-26 22:31:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637973002/1
4 years, 11 months ago (2016-01-28 00:07:51 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-28 00:57:04 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-28 01:16:33 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53cd62240b689e5fd8876580fff33a06c866928f
Cr-Commit-Position: refs/heads/master@{#371948}

Powered by Google App Engine
This is Rietveld 408576698