Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1280)

Unified Diff: ui/views/controls/menu/menu_image_util.h

Issue 1637973002: Vectorize menu radio buttons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/vector_icons/menu_radio_selected.icon ('k') | ui/views/controls/menu/menu_image_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/menu/menu_image_util.h
diff --git a/ui/views/controls/menu/menu_image_util.h b/ui/views/controls/menu/menu_image_util.h
index cd7a352f8fff8db59f35f126236e744dda4e2dd7..5097c4852f9e9e13f9af85f404063e9a67afcf78 100644
--- a/ui/views/controls/menu/menu_image_util.h
+++ b/ui/views/controls/menu/menu_image_util.h
@@ -17,10 +17,13 @@ const int kSubmenuArrowSize = 8;
// Returns the Menu Check box image (always checked).
gfx::ImageSkia GetMenuCheckImage(SkColor icon_color);
-// Return the RadioButton image for given state.
-// It returns the "selected" image when |selected| is
-// true, or the "unselected" image if false.
-gfx::ImageSkia GetRadioButtonImage(bool selected);
+// Return the RadioButton image for given state. |toggled| is true when
+// the radio option is active, |hovered| describes the menu higlight/selection
sadrul 2016/01/26 21:59:30 "the radio option is active" would 'selected' be b
Evan Stade 2016/01/26 22:31:53 I avoided the word selection because it's ambiguou
+// state, and |default_icon_color| is the base color that should be used for
+// the icon (which may be ignored based on the other two flags).
+gfx::ImageSkia GetRadioButtonImage(bool toggled,
+ bool hovered,
+ SkColor default_icon_color);
// Returns the image for submenu arrow for current RTL setting.
gfx::ImageSkia GetSubmenuArrowImage(SkColor icon_color);
« no previous file with comments | « ui/gfx/vector_icons/menu_radio_selected.icon ('k') | ui/views/controls/menu/menu_image_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698