Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Unified Diff: base/trace_event/tracing_agent.h

Issue 1637933002: trace_controller: Makes StopTracing callback ignore empty event strings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/tracing/tracing_controller_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/tracing_agent.h
diff --git a/base/trace_event/tracing_agent.h b/base/trace_event/tracing_agent.h
index f8ca78e92dbd07240210249b89db2ed4ecb21b5a..259ff0773dfeb2f47be6ed719df91fc0af42b410 100644
--- a/base/trace_event/tracing_agent.h
+++ b/base/trace_event/tracing_agent.h
@@ -26,6 +26,8 @@ class TraceConfig;
// system trace and PowerTracingAgent for BattOr power trace.
class BASE_EXPORT TracingAgent {
public:
+ // Passing a null or empty events_str_ptr indicates that no trace data is
+ // available for the specified agent.
charliea (OOO until 10-5) 2016/01/26 17:58:57 Here I chose to treat both null and empty events_s
using StopAgentTracingCallback = base::Callback<void(
const std::string& agent_name,
const std::string& events_label,
« no previous file with comments | « no previous file | content/browser/tracing/tracing_controller_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698