content/browser/tracing/tracing_controller_impl.cc - Issue 1637933002: trace_controller: Makes StopTracing callback ignore empty event strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/tracing/tracing_controller_impl.cc

Issue 1637933002: trace_controller: Makes StopTracing callback ignore empty event strings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/tracing/tracing_controller_impl.cc

diff --git a/content/browser/tracing/tracing_controller_impl.cc b/content/browser/tracing/tracing_controller_impl.cc

index 70edf234be4be8849a0883912a32216293d48130..52e3047791b95bd39451d459856ed664d391d80e 100644

--- a/content/browser/tracing/tracing_controller_impl.cc

+++ b/content/browser/tracing/tracing_controller_impl.cc

@@ -701,7 +701,7 @@ void TracingControllerImpl::OnEndAgentTracingAcked(

const scoped_refptr<base::RefCountedString>& events_str_ptr) {

DCHECK_CURRENTLY_ON(BrowserThread::UI);

- if (trace_data_sink_.get()) {

+ if (trace_data_sink_.get() && events_str_ptr && !events_str_ptr->empty()) {

std::string json_string;

if (agent_name == kETWTracingAgentName) {

// The Windows kernel events are kept into a JSON format stored as string

« base/trace_event/tracing_agent.h ('K') | « base/trace_event/tracing_agent.h ('k') | no next file » | no next file with comments »