Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1637813002:
Change Event.deepPath to a method (Closed)
|
Created:
4 years, 11 months ago by yuzuchan Modified:
4 years, 10 months ago CC:
blink-reviews, chromium-reviews, falken, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, tzik Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionChange Event.deepPath to a method
In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>.
See the discussion here: https://github.com/w3c/webcomponents/issues/361
Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-EventTarget
See the spec change here: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76c87d56c
BUG=531990
Committed: https://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957
Cr-Commit-Position: refs/heads/master@{#372596}
Committed: https://crrev.com/074da65f2d82b187dc44c5c5be09d3fec100d63d
Cr-Commit-Position: refs/heads/master@{#376103}
Committed: https://crrev.com/78dc6befc74f8b7b823eb071c16ea2bc6a3c3314
Cr-Commit-Position: refs/heads/master@{#376395}
Patch Set 1 #Patch Set 2 : Change return type #Patch Set 3 : Fix Tooltip.js #Patch Set 4 : Rebase #
Total comments: 2
Patch Set 5 : Remove unnecessary change #Messages
Total messages: 55 (22 generated)
Description was changed from ========== Change deepPath to a method. BUG= ========== to ========== Change Event.deepPath to a method BUG=531990 ==========
Description was changed from ========== Change Event.deepPath to a method BUG=531990 ========== to ========== Change Event.deepPath to a method Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-... BUG=531990 ==========
yuzus@chromium.org changed reviewers: + hayato@chromium.org, kochi@chromium.org, kojii@chromium.org
On 2016/01/26 06:36:17, yuzuchan wrote: Probably it's better to describe why the change was made in the CL description. https://github.com/w3c/webcomponents/issues/361 (issue, discussion) https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76... (change in spec) As the shadow DOM spec is a living standard, sometimes it's hard to figure out the reason of the change if only there is a link to the then-current spec (which will be obsolete later time).
Description was changed from ========== Change Event.deepPath to a method Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-... BUG=531990 ========== to ========== Change Event.deepPath to a method In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>. See the discussion here: https://github.com/w3c/webcomponents/issues/361 Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-... BUG=531990 ==========
Description was changed from ========== Change Event.deepPath to a method In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>. See the discussion here: https://github.com/w3c/webcomponents/issues/361 Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-... BUG=531990 ========== to ========== Change Event.deepPath to a method In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>. See the discussion here: https://github.com/w3c/webcomponents/issues/361 Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-... See the spec change here: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76... BUG=531990 ==========
Description was changed from ========== Change Event.deepPath to a method In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>. See the discussion here: https://github.com/w3c/webcomponents/issues/361 Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-... See the spec change here: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76... BUG=531990 ========== to ========== Change Event.deepPath to a method In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>. See the discussion here: https://github.com/w3c/webcomponents/issues/361 Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-... See the spec change here: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76... BUG=531990 ==========
On 2016/01/27 06:14:09, kochi wrote: > On 2016/01/26 06:36:17, yuzuchan wrote: > > Probably it's better to describe why the change was made in the CL description. > > https://github.com/w3c/webcomponents/issues/361 (issue, discussion) > https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76... > (change in spec) > > As the shadow DOM spec is a living standard, sometimes it's hard to figure > out the reason of the change if only there is a link to the then-current spec > (which will be obsolete later time). Thank you kochi@ san! I added a brief reason for the change and the links you mentioned to the description.
lgtm (but you also need OWNERS review)
It looks some tests are failing: https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_r... https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_r... It says: > Uncaught exception in inspector front-end: Uncaught TypeError: path[Symbol.iterator] is not a function [TypeError: path[Symbol.iterator] is not a function The error looks related to this CL.
On 2016/01/27 16:00:53, hayato wrote: > It looks some tests are failing: > > https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_r... > https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_r... > > It says: > > > Uncaught exception in inspector front-end: Uncaught TypeError: > path[Symbol.iterator] is not a function [TypeError: path[Symbol.iterator] is not > a function > > The error looks related to this CL. Thanks for mentioning it, I fixed the inspector javascript code.
On 2016/01/27 16:00:53, hayato wrote: > It looks some tests are failing: > > https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_r... > https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_r... > > It says: > > > Uncaught exception in inspector front-end: Uncaught TypeError: > path[Symbol.iterator] is not a function [TypeError: path[Symbol.iterator] is not > a function > > The error looks related to this CL. Thanks for mentioning it, I fixed the inspector javascript code.
yuzus@chromium.org changed reviewers: + samli@chromium.org
PTAL
PTAL
lgtm samli@, could you take a look at inspector part?
lgtm devtools changes.
The CQ bit was checked by yuzus@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637813002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637813002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
lgtm
The CQ bit was checked by yuzus@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637813002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637813002/40001
Message was sent while issue was closed.
Description was changed from ========== Change Event.deepPath to a method In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>. See the discussion here: https://github.com/w3c/webcomponents/issues/361 Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-... See the spec change here: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76... BUG=531990 ========== to ========== Change Event.deepPath to a method In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>. See the discussion here: https://github.com/w3c/webcomponents/issues/361 Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-... See the spec change here: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76... BUG=531990 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Change Event.deepPath to a method In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>. See the discussion here: https://github.com/w3c/webcomponents/issues/361 Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-... See the spec change here: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76... BUG=531990 ========== to ========== Change Event.deepPath to a method In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>. See the discussion here: https://github.com/w3c/webcomponents/issues/361 Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-... See the spec change here: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76... BUG=531990 Committed: https://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957 Cr-Commit-Position: refs/heads/master@{#372596} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957 Cr-Commit-Position: refs/heads/master@{#372596}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1651193003/ by kozyatinskiy@chromium.org. The reason for reverting is: This breaks new DevTools frontend while remote debugging old backends..
Message was sent while issue was closed.
On 2016/02/01 at 19:06:17, kozyatinskiy wrote: > A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1651193003/ by kozyatinskiy@chromium.org. > > The reason for reverting is: This breaks new DevTools frontend while remote debugging old backends.. I'm investigating the DevTools side now.
Message was sent while issue was closed.
On 2016/02/01 at 19:15:51, samli wrote: > On 2016/02/01 at 19:06:17, kozyatinskiy wrote: > > A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1651193003/ by kozyatinskiy@chromium.org. > > > > The reason for reverting is: This breaks new DevTools frontend while remote debugging old backends.. > > I'm investigating the DevTools side now. Devtools patch up at https://codereview.chromium.org/1653213002 Please rebase after that patch and then reland. Thanks.
Message was sent while issue was closed.
It looks https://codereview.chromium.org/1653213002 was already landed. Yuzu, could you reland this CL after rebasing?
Message was sent while issue was closed.
Description was changed from ========== Change Event.deepPath to a method In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>. See the discussion here: https://github.com/w3c/webcomponents/issues/361 Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-... See the spec change here: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76... BUG=531990 Committed: https://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957 Cr-Commit-Position: refs/heads/master@{#372596} ========== to ========== Change Event.deepPath to a method In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>. See the discussion here: https://github.com/w3c/webcomponents/issues/361 Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-... See the spec change here: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76... BUG=531990 Committed: https://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957 Cr-Commit-Position: refs/heads/master@{#372596} ==========
The CQ bit was checked by yuzus@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from hayato@chromium.org, samli@chromium.org, kochi@chromium.org Link to the patchset: https://codereview.chromium.org/1637813002/#ps60001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637813002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637813002/60001
Message was sent while issue was closed.
Description was changed from ========== Change Event.deepPath to a method In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>. See the discussion here: https://github.com/w3c/webcomponents/issues/361 Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-... See the spec change here: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76... BUG=531990 Committed: https://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957 Cr-Commit-Position: refs/heads/master@{#372596} ========== to ========== Change Event.deepPath to a method In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>. See the discussion here: https://github.com/w3c/webcomponents/issues/361 Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-... See the spec change here: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76... BUG=531990 Committed: https://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957 Cr-Commit-Position: refs/heads/master@{#372596} ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Change Event.deepPath to a method In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>. See the discussion here: https://github.com/w3c/webcomponents/issues/361 Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-... See the spec change here: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76... BUG=531990 Committed: https://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957 Cr-Commit-Position: refs/heads/master@{#372596} ========== to ========== Change Event.deepPath to a method In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>. See the discussion here: https://github.com/w3c/webcomponents/issues/361 Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-... See the spec change here: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76... BUG=531990 Committed: https://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957 Cr-Commit-Position: refs/heads/master@{#372596} Committed: https://crrev.com/074da65f2d82b187dc44c5c5be09d3fec100d63d Cr-Commit-Position: refs/heads/master@{#376103} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/074da65f2d82b187dc44c5c5be09d3fec100d63d Cr-Commit-Position: refs/heads/master@{#376103}
Message was sent while issue was closed.
On 2016/02/15 04:34:38, hayato wrote: > It looks https://codereview.chromium.org/1653213002 was already landed. > > Yuzu, could you reland this CL after rebasing? Done!
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/1710893003/ by pfeldman@chromium.org. The reason for reverting is: Breaks devtools. Landed without devtools review..
Message was sent while issue was closed.
https://codereview.chromium.org/1637813002/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/ui/Tooltip.js (right): https://codereview.chromium.org/1637813002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/ui/Tooltip.js:36: var path = event.deepPath() ? event.deepPath() : event.path; Remove this change please.
Message was sent while issue was closed.
Description was changed from ========== Change Event.deepPath to a method In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>. See the discussion here: https://github.com/w3c/webcomponents/issues/361 Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-... See the spec change here: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76... BUG=531990 Committed: https://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957 Cr-Commit-Position: refs/heads/master@{#372596} Committed: https://crrev.com/074da65f2d82b187dc44c5c5be09d3fec100d63d Cr-Commit-Position: refs/heads/master@{#376103} ========== to ========== Change Event.deepPath to a method In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>. See the discussion here: https://github.com/w3c/webcomponents/issues/361 Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-... See the spec change here: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76... BUG=531990 Committed: https://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957 Cr-Commit-Position: refs/heads/master@{#372596} Committed: https://crrev.com/074da65f2d82b187dc44c5c5be09d3fec100d63d Cr-Commit-Position: refs/heads/master@{#376103} ==========
https://codereview.chromium.org/1637813002/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/ui/Tooltip.js (right): https://codereview.chromium.org/1637813002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/ui/Tooltip.js:36: var path = event.deepPath() ? event.deepPath() : event.path; On 2016/02/18 22:48:29, samli wrote: > Remove this change please. Done.
The CQ bit was checked by yuzus@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from hayato@chromium.org, samli@chromium.org, kochi@chromium.org Link to the patchset: https://codereview.chromium.org/1637813002/#ps80001 (title: "Remove unnecessary change")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637813002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637813002/80001
pfeldman@, samli@ Could you review the latest patch set in terms of devtools? We do not want to break devtoos.
lgtm
Message was sent while issue was closed.
Description was changed from ========== Change Event.deepPath to a method In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>. See the discussion here: https://github.com/w3c/webcomponents/issues/361 Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-... See the spec change here: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76... BUG=531990 Committed: https://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957 Cr-Commit-Position: refs/heads/master@{#372596} Committed: https://crrev.com/074da65f2d82b187dc44c5c5be09d3fec100d63d Cr-Commit-Position: refs/heads/master@{#376103} ========== to ========== Change Event.deepPath to a method In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>. See the discussion here: https://github.com/w3c/webcomponents/issues/361 Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-... See the spec change here: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76... BUG=531990 Committed: https://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957 Cr-Commit-Position: refs/heads/master@{#372596} Committed: https://crrev.com/074da65f2d82b187dc44c5c5be09d3fec100d63d Cr-Commit-Position: refs/heads/master@{#376103} ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Change Event.deepPath to a method In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>. See the discussion here: https://github.com/w3c/webcomponents/issues/361 Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-... See the spec change here: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76... BUG=531990 Committed: https://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957 Cr-Commit-Position: refs/heads/master@{#372596} Committed: https://crrev.com/074da65f2d82b187dc44c5c5be09d3fec100d63d Cr-Commit-Position: refs/heads/master@{#376103} ========== to ========== Change Event.deepPath to a method In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>. See the discussion here: https://github.com/w3c/webcomponents/issues/361 Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-... See the spec change here: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76... BUG=531990 Committed: https://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957 Cr-Commit-Position: refs/heads/master@{#372596} Committed: https://crrev.com/074da65f2d82b187dc44c5c5be09d3fec100d63d Cr-Commit-Position: refs/heads/master@{#376103} Committed: https://crrev.com/78dc6befc74f8b7b823eb071c16ea2bc6a3c3314 Cr-Commit-Position: refs/heads/master@{#376395} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/78dc6befc74f8b7b823eb071c16ea2bc6a3c3314 Cr-Commit-Position: refs/heads/master@{#376395} |
