Issue 1637693002: Fix a bunch of pointless returns.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1637693002: Fix a bunch of pointless returns. (Closed)

Created:
4 years, 11 months ago by Lei Zhang

Modified:
4 years, 11 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -11 lines)			Patch
	M	fpdfsdk/src/fsdk_annothandler.cpp	View		2 chunks	+2 lines, -6 lines	0 comments	Download
	M	fpdfsdk/src/fsdk_baseannot.cpp	View		2 chunks	+1 line, -5 lines	0 comments	Download

Total messages: 4 (1 generated)

Lei Zhang

TBR, basically https://codereview.chromium.org/1635853002 minus xfa/

4 years, 11 months ago (2016-01-26 00:40:05 UTC) #1

Lei Zhang

Committed patchset #3 (id:40001) manually as e56b3ad57573c677ad84bf4a2ffd649d6134b990 (presubmit successful).

4 years, 11 months ago (2016-01-26 00:41:03 UTC) #3

Message was sent while issue was closed.

lgtm