Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1635853002: XFA: Fix a bunch of pointless returns. (Closed)

Created:
4 years, 11 months ago by Lei Zhang
Modified:
4 years, 11 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

XFA: Fix a bunch of pointless returns. And a few other nits. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/05e67415684adc36af228ca2f1e0efc30a40d242

Patch Set 1 #

Total comments: 6

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -22 lines) Patch
M fpdfsdk/src/fsdk_annothandler.cpp View 1 2 chunks +2 lines, -6 lines 0 comments Download
M fpdfsdk/src/fsdk_baseannot.cpp View 1 chunk +2 lines, -6 lines 0 comments Download
M xfa/src/fee/src/fee/fde_txtedtengine.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fee/src/fee/fde_txtedtpage.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_monthcalendarimp.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/fm2js/xfa_fm2jscontext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/fm2js/xfa_simpleexpression.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/parser/xfa_layout_itemlayout.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/parser/xfa_script_resolveprocessor.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Lei Zhang
4 years, 11 months ago (2016-01-26 00:11:09 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1635853002/diff/1/fpdfsdk/src/fsdk_annothandler.cpp File fpdfsdk/src/fsdk_annothandler.cpp (left): https://codereview.chromium.org/1635853002/diff/1/fpdfsdk/src/fsdk_annothandler.cpp#oldcode243 fpdfsdk/src/fsdk_annothandler.cpp:243: if (IPDFSDK_AnnotHandler* pAnnotHandler = GetAnnotHandler(pAnnot)) { nit: no ...
4 years, 11 months ago (2016-01-26 00:15:38 UTC) #3
Lei Zhang
https://codereview.chromium.org/1635853002/diff/1/fpdfsdk/src/fsdk_annothandler.cpp File fpdfsdk/src/fsdk_annothandler.cpp (left): https://codereview.chromium.org/1635853002/diff/1/fpdfsdk/src/fsdk_annothandler.cpp#oldcode243 fpdfsdk/src/fsdk_annothandler.cpp:243: if (IPDFSDK_AnnotHandler* pAnnotHandler = GetAnnotHandler(pAnnot)) { On 2016/01/26 00:15:38, ...
4 years, 11 months ago (2016-01-26 00:31:02 UTC) #4
Lei Zhang
4 years, 11 months ago (2016-01-26 00:35:48 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
05e67415684adc36af228ca2f1e0efc30a40d242 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698