chrome/browser/ui/views/external_protocol_dialog.cc - Issue 16374006: Place browser-modal dialogs like web-contents-modal dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/external_protocol_dialog.cc

Issue 16374006: Place browser-modal dialogs like web-contents-modal dialogs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Revert changes to c/b/chromeos files for now. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/external_protocol_dialog.cc

diff --git a/chrome/browser/ui/views/external_protocol_dialog.cc b/chrome/browser/ui/views/external_protocol_dialog.cc

index 4f19e29da30f896b5516e92d3e33bd6cecc56700..8f0a8fbd04948267f3833d9bb8bb0cd583c422bd 100644

--- a/chrome/browser/ui/views/external_protocol_dialog.cc

+++ b/chrome/browser/ui/views/external_protocol_dialog.cc

@@ -12,6 +12,7 @@

#include "base/win/registry.h"

#include "chrome/browser/external_protocol/external_protocol_handler.h"

#include "chrome/browser/tab_contents/tab_util.h"

+#include "chrome/browser/ui/views/constrained_window_views.h"

#include "content/public/browser/web_contents.h"

#include "content/public/browser/web_contents_view.h"

#include "grit/chromium_strings.h"

@@ -161,7 +162,7 @@ ExternalProtocolDialog::ExternalProtocolDialog(WebContents* web_contents,

GA_ROOT);

}

- views::DialogDelegate::CreateDialogWidget(this, NULL, root_hwnd)->Show();

+ CreateBrowserModalDialogViews(this, root_hwnd)->Show();

}

// static