Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: chrome/browser/ui/views/javascript_app_modal_dialog_views.cc

Issue 16374006: Place browser-modal dialogs like web-contents-modal dialogs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Revert changes to c/b/chromeos files for now. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/javascript_app_modal_dialog_views.cc
diff --git a/chrome/browser/ui/views/javascript_app_modal_dialog_views.cc b/chrome/browser/ui/views/javascript_app_modal_dialog_views.cc
index fb89b4cd5221c09eae913b2750ee0cda7675c7b6..d4981e36735d2c2c637c9ea2c8f42950da55ec4c 100644
--- a/chrome/browser/ui/views/javascript_app_modal_dialog_views.cc
+++ b/chrome/browser/ui/views/javascript_app_modal_dialog_views.cc
@@ -6,6 +6,7 @@
#include "base/utf_string_conversions.h"
#include "chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.h"
+#include "chrome/browser/ui/views/constrained_window_views.h"
#include "grit/generated_resources.h"
#include "ui/base/keycodes/keyboard_codes.h"
#include "ui/base/l10n/l10n_util.h"
@@ -162,16 +163,6 @@ NativeAppModalDialog* NativeAppModalDialog::CreateNativeJavaScriptPrompt(
JavaScriptAppModalDialog* dialog,
gfx::NativeWindow parent_window) {
JavaScriptAppModalDialogViews* d = new JavaScriptAppModalDialogViews(dialog);
- views::Widget* widget =
- views::DialogDelegate::CreateDialogWidget(d, NULL, parent_window);
- views::Widget* parent_widget = parent_window ?
- views::Widget::GetWidgetForNativeWindow(parent_window) : NULL;
- // Horizontally center the dialog window within the parent window's bounds.
- if (widget && parent_widget) {
- gfx::Rect bounds(widget->GetWindowBoundsInScreen());
- gfx::Rect parent_bounds(parent_widget->GetWindowBoundsInScreen());
- bounds.set_x(parent_bounds.CenterPoint().x() - bounds.width() / 2);
- widget->SetBounds(bounds);
- }
+ CreateBrowserModalDialogViews(d, parent_window);
return d;
}
« no previous file with comments | « chrome/browser/ui/views/external_protocol_dialog.cc ('k') | chrome/browser/ui/views/simple_message_box_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698