Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Issue 16374004: Revert 204046 "Land Recent QUIC changes." (Closed)

Created:
7 years, 6 months ago by ramant (doing other things)
Modified:
7 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 204046 "Land Recent QUIC changes." > Land Recent QUIC changes. > > Merge internal change: 47341065 > > Fix to ensure the version matches before declaring that the public header > flags exceed the max value. b/9190456 > > Merge internal change: 47324563 > > Fixing another backup bug (exposed by the last fix) that if we failed to > write a standalone fin the stream would not be marked as write blocked. > > Merge internal change: 47272116 > > Don't add QuicStreams to ActiveSessionList; Instead call DumpSession on > alive streams via QuicSession. > > Merge internal change: 47226512 > > Making the packet sequence number variable length to minimize bytes on the wire. > > Merge internal change: 47220850 > > Fixing a bug in quic stream where we'd send rst stream packets for > successful streams. The fin bit should be sufficient for both good > request/response pairs and early response pairs. > > Merge internal change: 47086343 > > Don't let FEC packets consume congestion window forever. If a FEC packet > is not acked after a certain time, it is cleared from the congestion > window. This timeout is higher than normal RTO. > > Merge internal change: 47056082 > > Add QuicSession to ActiveSessionList. > > Merge internal change: 47048300 > > Fixing a backup/resumption bug in QUIC. > > It's possible to have a full congestion window worth of packets on the wire. > > If we are in this state and a session tries to SendStreamData, the > QuicPacketGenerator short-circuits without queuing packets because it checks > to see if the connection CanWrite. > > When we get an ack, we check to see if we have locally queued packets, but > never call OnCanWrite on the session to clear any streams which write blocked > without queueing packets. > > Merge internal change: 47000173 > > QUIC: wire up the server-nonce parameters to the server config. > > Merge internal change: 46985067 > > R=rch@chromium.org > > Review URL: https://codereview.chromium.org/16256017 TBR=rtenneti@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204062

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+413 lines, -1194 lines) Patch
M trunk/src/net/quic/congestion_control/quic_congestion_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/net/quic/crypto/crypto_server_config.h View 1 chunk +0 lines, -15 lines 0 comments Download
M trunk/src/net/quic/crypto/crypto_server_config.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M trunk/src/net/quic/quic_connection.h View 6 chunks +18 lines, -43 lines 0 comments Download
M trunk/src/net/quic/quic_connection.cc View 15 chunks +55 lines, -120 lines 0 comments Download
M trunk/src/net/quic/quic_connection_test.cc View 32 chunks +41 lines, -100 lines 0 comments Download
M trunk/src/net/quic/quic_framer.h View 3 chunks +5 lines, -8 lines 0 comments Download
M trunk/src/net/quic/quic_framer.cc View 33 chunks +58 lines, -154 lines 0 comments Download
M trunk/src/net/quic/quic_framer_test.cc View 72 chunks +103 lines, -497 lines 0 comments Download
M trunk/src/net/quic/quic_http_stream_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/net/quic/quic_packet_creator.h View 3 chunks +5 lines, -9 lines 0 comments Download
M trunk/src/net/quic/quic_packet_creator.cc View 6 chunks +2 lines, -9 lines 0 comments Download
M trunk/src/net/quic/quic_packet_creator_test.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/net/quic/quic_protocol.h View 9 chunks +28 lines, -50 lines 0 comments Download
M trunk/src/net/quic/quic_protocol.cc View 5 chunks +26 lines, -30 lines 0 comments Download
M trunk/src/net/quic/quic_session.h View 4 chunks +0 lines, -11 lines 0 comments Download
M trunk/src/net/quic/quic_session.cc View 8 chunks +8 lines, -15 lines 0 comments Download
M trunk/src/net/quic/quic_stream_factory_test.cc View 8 chunks +47 lines, -12 lines 0 comments Download
M trunk/src/net/quic/reliable_quic_stream.cc View 3 chunks +1 line, -9 lines 0 comments Download
M trunk/src/net/quic/reliable_quic_stream_test.cc View 4 chunks +2 lines, -62 lines 0 comments Download
M trunk/src/net/quic/test_tools/quic_framer_peer.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/net/quic/test_tools/quic_framer_peer.cc View 1 chunk +1 line, -3 lines 0 comments Download
M trunk/src/net/quic/test_tools/quic_session_peer.h View 2 chunks +0 lines, -6 lines 0 comments Download
M trunk/src/net/quic/test_tools/quic_session_peer.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M trunk/src/net/quic/test_tools/quic_test_utils.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M trunk/src/net/tools/quic/end_to_end_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/net/tools/quic/quic_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/net/tools/quic/quic_epoll_connection_helper_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/tools/quic/quic_server.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/net/tools/quic/quic_server_session.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/net/tools/quic/quic_server_session.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
7 years, 6 months ago (2013-06-04 22:19:08 UTC) #1
ramant (doing other things)
7 years, 6 months ago (2013-06-04 22:20:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r204062.

Powered by Google App Engine
This is Rietveld 408576698